From ba39516afb08dc6f6e7598c171d4c8af53400e29 Mon Sep 17 00:00:00 2001
From: digiwand <20778143+digiwand@users.noreply.github.com>
Date: Thu, 3 Aug 2023 16:50:54 +0200
Subject: [PATCH] BlockaidBannerAlert: update tkeys based on reason

---
 .../blockaid-banner-alert.js                  | 28 ++++++++-----------
 1 file changed, 11 insertions(+), 17 deletions(-)

diff --git a/ui/components/app/security-provider-banner-alert/blockaid-banner-alert/blockaid-banner-alert.js b/ui/components/app/security-provider-banner-alert/blockaid-banner-alert/blockaid-banner-alert.js
index 9005963fe742..51d11cf7dfa8 100644
--- a/ui/components/app/security-provider-banner-alert/blockaid-banner-alert/blockaid-banner-alert.js
+++ b/ui/components/app/security-provider-banner-alert/blockaid-banner-alert/blockaid-banner-alert.js
@@ -21,6 +21,8 @@ const REASON_TO_DESCRIPTION_TKEY = Object.freeze({
 
   [BlockaidReason.blurFarming]: 'blockaidDescriptionBlurFarming',
 
+  [BlockaidReason.failed]: 'blockaidDescriptionFailed',
+
   [BlockaidReason.seaportFarming]: 'blockaidDescriptionSeaportFarming',
 
   [BlockaidReason.maliciousDomain]: 'blockaidDescriptionMaliciousDomain',
@@ -36,8 +38,11 @@ const REASON_TO_DESCRIPTION_TKEY = Object.freeze({
   [BlockaidReason.other]: 'blockaidDescriptionMightLoseAssets',
 });
 
-/** List of suspicious reason(s). Other reasons will be deemed as deceptive. */
-const SUSPCIOUS_REASON = [BlockaidReason.rawSignatureFarming];
+/** Reason to title translation key mapping. */
+const REASON_TO_TITLE_TKEY = Object.freeze({
+  [BlockaidReason.failed]: 'blockaidTitleMayNotBeSafe',
+  [BlockaidReason.rawSignatureFarming]: 'blockaidDescriptionApproveFarming',
+});
 
 function BlockaidBannerAlert({ securityAlertResponse }) {
   const t = useContext(I18nContext);
@@ -52,16 +57,12 @@ function BlockaidBannerAlert({ securityAlertResponse }) {
     return null;
   }
 
-  const descriptionTKey =
-    resultType === BlockaidResultType.Failed
-      ? 'blockaidDescriptionFailed'
-      : REASON_TO_DESCRIPTION_TKEY[reason];
-  const description = t(descriptionTKey || 'other');
-
-  if (!descriptionTKey) {
+  if (!REASON_TO_DESCRIPTION_TKEY[reason]) {
     captureException(`BlockaidBannerAlert: Unidentified reason '${reason}'`);
   }
 
+  const description = t(REASON_TO_DESCRIPTION_TKEY[reason] || 'other');
+
   const details = Boolean(features?.length) && (
     <Text as="ul">
       {features.map((feature, i) => (
@@ -75,14 +76,7 @@ function BlockaidBannerAlert({ securityAlertResponse }) {
       ? Severity.Danger
       : Severity.Warning;
 
-  let title;
-  if (resultType === BlockaidResultType.Failed) {
-    title = t('blockaidTitleMayNotBeSafe');
-  } else if (SUSPCIOUS_REASON.indexOf(reason) > -1) {
-    title = t('blockaidTitleSuspicious');
-  } else {
-    title = t('blockaidTitleDeceptive');
-  }
+  const title = REASON_TO_TITLE_TKEY[reason] || t('blockaidTitleDeceptive');
 
   return (
     <SecurityProviderBannerAlert