Skip to content

Commit

Permalink
Remove delays from onboarding tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@darkwing
darkwing committed Oct 16, 2024
1 parent ec4fb5f commit e5a2b3f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 39 deletions.
31 changes: 5 additions & 26 deletions test/e2e/tests/onboarding/onboarding.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,7 @@ const {
onboardingCreatePassword,
onboardingRevealAndConfirmSRP,
onboardingCompleteWalletCreation,
regularDelayMs,
unlockWallet,
tinyDelayMs,
largeDelayMs,
} = require('../../helpers');
const FixtureBuilder = require('../../fixture-builder');
const {
Expand Down Expand Up @@ -287,7 +284,7 @@ describe('MetaMask onboarding @no-mmi', function () {
await driver.clickElement({
text: 'General',
});
await driver.delay(largeDelayMs);

await driver.clickElement({ text: 'Add a network' });

await driver.waitForSelector(
Expand All @@ -308,12 +305,10 @@ describe('MetaMask onboarding @no-mmi', function () {
);

// Add rpc url
const rpcUrlInputDropDown = await driver.waitForSelector(
await driver.waitForSelector(
'[data-testid="test-add-rpc-drop-down"]',
);
await driver.delay(tinyDelayMs);
await rpcUrlInputDropDown.click();
await driver.delay(tinyDelayMs);
await driver.clickElement('[data-testid="test-add-rpc-drop-down"]');
await driver.clickElement({
text: 'Add RPC URL',
tag: 'button',
Expand All @@ -330,24 +325,15 @@ describe('MetaMask onboarding @no-mmi', function () {

await driver.clickElement({ text: 'Save', tag: 'button' });

await driver.delay(largeDelayMs);
await driver.waitForSelector('[data-testid="category-back-button"]');
const generalBackButton = await driver.waitForSelector(
'[data-testid="category-back-button"]',
);
await generalBackButton.click();

await driver.delay(largeDelayMs);
await driver.clickElement('[data-testid="category-back-button"]');

await driver.waitForSelector(
'[data-testid="privacy-settings-back-button"]',
);
const defaultSettingsBackButton = await driver.findElement(
await driver.clickElement(
'[data-testid="privacy-settings-back-button"]',
);
await defaultSettingsBackButton.click();

await driver.delay(largeDelayMs);

await driver.clickElement({
text: 'Done',
Expand All @@ -359,8 +345,6 @@ describe('MetaMask onboarding @no-mmi', function () {
tag: 'button',
});

await driver.delay(largeDelayMs);

await driver.clickElement({
text: 'Done',
tag: 'button',
Expand All @@ -370,7 +354,6 @@ describe('MetaMask onboarding @no-mmi', function () {
await driver.clickElement(
`[data-rbd-draggable-id="${toHex(chainId)}"]`,
);
await driver.delay(largeDelayMs);
// Check localhost 8546 is selected and its balance value is correct
await driver.findElement({
css: '[data-testid="network-display"]',
Expand Down Expand Up @@ -523,8 +506,6 @@ describe('MetaMask onboarding @no-mmi', function () {
// pin extension walkthrough screen
await driver.clickElement('[data-testid="pin-extension-next"]');

await driver.delay(regularDelayMs);

for (let i = 0; i < mockedEndpoints.length; i += 1) {
const mockedEndpoint = await mockedEndpoints[i];
const isPending = await mockedEndpoint.isPending();
Expand Down Expand Up @@ -652,8 +633,6 @@ describe('MetaMask onboarding @no-mmi', function () {

await importSRPOnboardingFlow(driver, TEST_SEED_PHRASE, password);

await driver.delay(regularDelayMs);

for (let i = 0; i < mockedEndpoints.length; i += 1) {
const mockedEndpoint = await mockedEndpoints[i];
const requests = await mockedEndpoint.getSeenRequests();
Expand Down
13 changes: 0 additions & 13 deletions test/e2e/tests/privacy/basic-functionality.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ const {
withFixtures,
importSRPOnboardingFlow,
WALLET_PASSWORD,
tinyDelayMs,
regularDelayMs,
largeDelayMs,
defaultGanacheOptions,
} = require('../../helpers');
const { METAMASK_STALELIST_URL } = require('../phishing-controller/helpers');
Expand Down Expand Up @@ -65,27 +62,21 @@ describe('MetaMask onboarding @no-mmi', function () {
});
await driver.clickElement('[data-testid="category-item-General"]');

await driver.delay(regularDelayMs);

await driver.clickElement(
'[data-testid="basic-functionality-toggle"] .toggle-button',
);

await driver.clickElement('[id="basic-configuration-checkbox"]');
await driver.clickElement({ text: 'Turn off', tag: 'button' });
await driver.clickElement('[data-testid="category-back-button"]');
await driver.delay(regularDelayMs);
await driver.clickElement('[data-testid="category-item-Assets"]');
await driver.delay(regularDelayMs);
await driver.clickElement(
'[data-testid="currency-rate-check-toggle"] .toggle-button',
);
await driver.clickElement('[data-testid="category-back-button"]');
await driver.delay(regularDelayMs);
await driver.clickElement(
'[data-testid="privacy-settings-back-button"]',
);
await driver.delay(regularDelayMs);

await driver.clickElement({ text: 'Done', tag: 'button' });
await driver.clickElement('[data-testid="pin-extension-next"]');
Expand All @@ -94,7 +85,6 @@ describe('MetaMask onboarding @no-mmi', function () {
await driver.clickElement('[data-testid="network-display"]');

await driver.clickElement({ text: 'Ethereum Mainnet', tag: 'p' });
await driver.delay(tinyDelayMs);

// Wait until network is fully switched and refresh tokens before asserting to mitigate flakiness
await driver.assertElementNotPresent('.loading-overlay');
Expand Down Expand Up @@ -134,13 +124,10 @@ describe('MetaMask onboarding @no-mmi', function () {
tag: 'button',
});
await driver.clickElement('[data-testid="category-item-General"]');
await driver.delay(largeDelayMs);
await driver.clickElement('[data-testid="category-back-button"]');
await driver.delay(largeDelayMs);
await driver.clickElement(
'[data-testid="privacy-settings-back-button"]',
);
await driver.delay(largeDelayMs);
await driver.clickElement({ text: 'Done', tag: 'button' });
await driver.clickElement('[data-testid="pin-extension-next"]');
await driver.clickElement({ text: 'Done', tag: 'button' });
Expand Down

0 comments on commit e5a2b3f

Please sign in to comment.