Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: bump
@metamask/queued-request controller
to ^2.0.0
to fix c…
…onfirmation popup focus in request queue (#25497) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25497?quickstart=1) ## **Related issues** See: MetaMask/core#4457 See: #25397 ## **Manual testing steps** 1. Ensure request queue is toggled on 2. In Tab 1, Visit the test dapp 3. run `await window.ethereum.request({method: 'wallet_switchEthereumChain', params: [{"chainId": "0xaa36a7"}]})` in console to change the network to sepolia for this dapp 4. In Tab 2, Visit a different dapp 5. run `await window.ethereum.request({method: 'wallet_switchEthereumChain', params: [{"chainId": "1"}]})` in console to change the network to mainnet for this dapp 6. In Tab 1, click the Send Transaction button, but ignore the confirmation notification (leave it open) 7. In Tab 2, run `await window.ethereum.request({method: 'eth_requestAccounts'})` 8. The confirmation notification window should be focused and visible now, but still be displaying the pending transaction from before ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/MetaMask/metamask-extension/assets/918701/48693083-fe60-402f-8798-c32b5db541b6 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information