-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Scan address not working - invalid address #14306
Comments
I think the issue here is how MM mobile is generating the QR codes. They are adding a specific pattern for identifying chain ids that extension doesn't use. cc: @omnat for awareness |
The pattern they are using: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-681.md |
Thanks @bschorchit I've double checked and QRs generated in other places (example) do work. Even though, isn't it problematic that QRs generated with MMobile are detected as invalid on MExtension? Should the issue be fixed on Mobile level, on the Extension level? or closed? |
It definitely is and I'm really glad you spotted it @seaona , because that was something we were not aware of! We're trying to understand the reasoning behind using that pattern for mobile so we decide on wether we should update extension or mobile codebases or on both when we have a final network specific address pattern decision. Relevant discussion is happening here. |
This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity.\n\nThe MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible.\n\nThank you for your contributions. |
We don't want this to be closed :) |
This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions. |
This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions. |
Describe the bug
Problem: when I want to send a transaction using the QR code scan for the address, I get "invalid address" even though if I introduce the address manually it works fine
recipient-invalid-scan.mp4
Steps to reproduce
You can use both this QR code and the associated address on the video, if convenient:
Error messages or log output
Version
10.13.0
Build type
No response
Browser
Firefox
Operating system
Linux
Hardware wallet
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: