Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Scan address not working - invalid address #14306

Closed
seaona opened this issue Mar 31, 2022 · 9 comments
Closed

[Bug]: Scan address not working - invalid address #14306

seaona opened this issue Mar 31, 2022 · 9 comments
Labels
mobile-compatibility Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-confirmations-planning (only for internal use within Confirmations team) type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Mar 31, 2022

Describe the bug

Problem: when I want to send a transaction using the QR code scan for the address, I get "invalid address" even though if I introduce the address manually it works fine

recipient-invalid-scan.mp4

Steps to reproduce

  1. Unlock Metamask
  2. Click Send
  3. Click Scan QR
  4. Scan QR code from an address

You can use both this QR code and the associated address on the video, if convenient:

  • 0xB32f46CcC19A4D2Dd46ea98d5c5F35763385aEDd

image

Error messages or log output

invalid address

Version

10.13.0

Build type

No response

Browser

Firefox

Operating system

Linux

Hardware wallet

No response

Additional context

No response

@bschorchit
Copy link

bschorchit commented Apr 4, 2022

I think the issue here is how MM mobile is generating the QR codes. They are adding a specific pattern for identifying chain ids that extension doesn't use.
Slack thread about it

cc: @omnat for awareness

@bschorchit
Copy link

The pattern they are using: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-681.md

@seaona
Copy link
Contributor Author

seaona commented Apr 5, 2022

Thanks @bschorchit I've double checked and QRs generated in other places (example) do work. Even though, isn't it problematic that QRs generated with MMobile are detected as invalid on MExtension? Should the issue be fixed on Mobile level, on the Extension level? or closed?

@bschorchit
Copy link

It definitely is and I'm really glad you spotted it @seaona , because that was something we were not aware of! We're trying to understand the reasoning behind using that pattern for mobile so we decide on wether we should update extension or mobile codebases or on both when we have a final network specific address pattern decision. Relevant discussion is happening here.
Let's keep this issue open until we have a fix for it.

@bschorchit bschorchit added type-bug Sev3-low Low severity; minimal to no impact upon users labels Apr 8, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity.\n\nThe MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible.\n\nThank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 20, 2023
@bschorchit
Copy link

We don't want this to be closed :)

@bschorchit bschorchit added team-confirmations-planning (only for internal use within Confirmations team) Sev2-normal Normal severity; minor loss of service or inconvenience. and removed Sev3-low Low severity; minimal to no impact upon users stale issues and PRs marked as stale labels Jul 20, 2023
@sleepytanya
Copy link
Contributor

sleepytanya commented Jul 24, 2023

Just adding my two cents.
The QRs are generated on mobile in two different ways.

  1. Click 'Receive' on mobile. Scan QR code with extension. You have to scan QR with 'Add a contact' feature to see the string, scanning with 'Send' will show just empty field and 'Invalid address" message.
Screenshot 2023-07-24 at 12 45 28 PM

The QR will look like this (with chain id attached):
Screenshot 2023-07-24 at 12 45 10 PM

  1. Click 'Receive' on mobile. Then click 'Request Payment'. Scan with 'Add a contact' to see the string. You will get this QR (with the value after chain id):
Screenshot 2023-07-24 at 12 30 57 PM

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Oct 22, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile-compatibility Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-confirmations-planning (only for internal use within Confirmations team) type-bug
Projects
None yet
Development

No branches or pull requests

3 participants