New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out if we can put the gridplus-sdk anywhere other than the background, or otherwise shrink it #15532

Open

danjm opened this issue Aug 10, 2022 · 1 comment

Labels

MV3 team-extension-platform

Contributor

danjm commented Aug 10, 2022

No description provided.

danjm added the MV3 label

hilvmason added team-extension-client team-extension-platform labels

gauthierpetetin removed the team-extension-client label

legobeat mentioned this issue

chore: Bump gridplus-sdk to 2.7.1 #28008

Merged

7 tasks

Contributor

legobeat commented Oct 24, 2024

Related:

github-merge-queue bot pushed a commit that referenced this issue


          chore: Bump gridplus-sdk to 2.7.1 (#28008)

fa895e5

## **Description**

Bump dependency `gridplus-sdk` to latest by lifting pin.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28008?quickstart=1)

## **Related issues**

- Follow-up to: #27973

#### Resolves
- #15927

#### Progresses
- #15532


## **Manual testing steps**

- Test basic GridPlus Lattic1 HW wallet flow


## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

vinistevam pushed a commit that referenced this issue


          chore: Bump gridplus-sdk to 2.7.1 (#28008)

253a545

## **Description**

Bump dependency `gridplus-sdk` to latest by lifting pin.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28008?quickstart=1)

## **Related issues**

- Follow-up to: #27973

#### Resolves
- #15927

#### Progresses
- #15532


## **Manual testing steps**

- Test basic GridPlus Lattic1 HW wallet flow


## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment