-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Button prop name type
to variant
#18693
Labels
good first issue
Good for newcomers
team-design-system
All issues relating to design system in Extension
Comments
georgewrmarshall
added
good first issue
Good for newcomers
team-design-system
All issues relating to design system in Extension
labels
Apr 20, 2023
@georgewrmarshall I would love to take this. Please can you assign this to me? |
Hey @hakeemullahjan, thanks for your interest. Assigned. Looking forward to your PR. Thanks! |
omraval18
added a commit
to omraval18/metamask-extension
that referenced
this issue
Apr 22, 2023
omraval18
added a commit
to omraval18/metamask-extension
that referenced
this issue
Apr 22, 2023
omraval18
added a commit
to omraval18/metamask-extension
that referenced
this issue
Apr 22, 2023
8 tasks
8 tasks
Hi @georgewrmarshall @hakeemullahjan, I'd like to assist to this issue |
Fixed by #18774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
team-design-system
All issues relating to design system in Extension
Description
Currently the prop to change the button style: PRIMARY, SECONDARY, LINK etc for the component-library
Button
component is calledtype
. It would be more consistent with the rest of our components of this prop was renamed tovariant
There should be only a few instances of the
Button
component from theui/components/component-library
folder so it should be ok to update all in one PRTechnical Details
BUTTON_TYPES
toBUTTON_VARIANT
type
prop tovariant
for theButton
componentAcceptance Criteria
type
prop have been updated tovariant
The text was updated successfully, but these errors were encountered: