Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: @lavamoat/allow-scripts@2.0.3->2.3.1 #20018

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

legobeat
Copy link
Contributor

Explanation

Maintenance update; security fixes

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat requested a review from a team July 13, 2023 23:20
@legobeat legobeat added type-security dependencies Pull requests that update a dependency file labels Jul 13, 2023
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from d94372e to 6918488 Compare July 13, 2023 23:30
@legobeat
Copy link
Contributor Author

legobeat commented Jul 14, 2023

re tests-deps-audit error: yarn npm audit is borked until yarn v4: yarnpkg/berry#4117

(endpoint returns HTTP 400 here)

@legobeat legobeat marked this pull request as ready for review July 14, 2023 00:48
@legobeat legobeat requested review from a team as code owners July 14, 2023 00:48
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch 7 times, most recently from 858554b to da1954f Compare July 18, 2023 00:36
Gudahtt
Gudahtt previously approved these changes Jul 18, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from da1954f to 0532a25 Compare July 18, 2023 07:22
mcmire
mcmire previously approved these changes Jul 18, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@legobeat legobeat dismissed stale reviews from mcmire and Gudahtt via f0c9bb5 July 18, 2023 23:11
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from 25650d4 to f0c9bb5 Compare July 18, 2023 23:11
@legobeat legobeat requested review from mcmire, Gudahtt and a team July 18, 2023 23:15
Gudahtt
Gudahtt previously approved these changes Jul 19, 2023
@legobeat legobeat requested a review from a team July 19, 2023 02:14
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch 2 times, most recently from 1478a53 to 1a0f742 Compare July 20, 2023 00:05
@legobeat legobeat requested a review from naugtur July 20, 2023 04:29
@Gudahtt
Copy link
Member

Gudahtt commented Jul 20, 2023

Hmm, another audit failure

@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from 0e41e0c to b5e1d1c Compare July 20, 2023 23:57
@legobeat
Copy link
Contributor Author

Hmm, another audit failure

Yes:


ERROR: Unable to parse yarn audit output: SyntaxError: Unexpected token ➤ in JSON at position 0
Try running `yarn audit` for more info

Exited with code exit status 1

re tests-deps-audit error: yarn npm audit is borked until yarn v4: yarnpkg/berry#4117

(endpoint returns HTTP 400 here)

#20018 (comment)

@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch 3 times, most recently from 289d637 to 35a7a32 Compare July 26, 2023 00:46
@kumavis
Copy link
Member

kumavis commented Jul 26, 2023

re tests-deps-audit error: yarn npm audit is borked until yarn v4: yarnpkg/berry#4117

linked issue seems irrelevant - underlying error is different

SyntaxError: Unexpected token ➤ in JSON at position 0

we're likely getting a non json error message from a json endpoint

@legobeat
Copy link
Contributor Author

legobeat commented Jul 26, 2023

re tests-deps-audit error: yarn npm audit is borked until yarn v4: yarnpkg/berry#4117

linked issue seems irrelevant - underlying error is different

SyntaxError: Unexpected token ➤ in JSON at position 0

we're likely getting a non json error message from a json endpoint

What do you see as different here? Both are due to the 400 from the npm audit backend.

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
No contributors or author data @pkgjs/parseargs 0.11.0
Unmaintained eastasianwidth 0.2.0
  • Last Publish: 1/1/2018, 9:26:07 AM

Next steps

Why is contributor and author data important?

Package does not specify a list of contributors or an author in package.json.

Add a author field or contributors array to package.json.

What are unmaintained packages?

Package has not been updated in more than a year and may be unmaintained. Problems with the package may go unaddressed.

Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @pkgjs/parseargs@0.11.0
  • @SocketSecurity ignore eastasianwidth@0.2.0

@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch 3 times, most recently from e150a72 to cddc9af Compare July 26, 2023 11:06
@legobeat legobeat requested a review from Gudahtt July 26, 2023 11:12
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from cddc9af to 39958dd Compare July 26, 2023 15:23
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from 39958dd to 6d6f055 Compare July 26, 2023 22:01
@legobeat legobeat merged commit 811d25c into MetaMask:develop Jul 26, 2023
8 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
@legobeat legobeat deleted the devdeps-lavamoat-allow-scripts branch July 26, 2023 22:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file type-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants