-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Element (0:) out of place in sign typed data v4 #21725
Comments
@benjisclowder I see the same Is there a reason it should not be there on v11.5.0 even though it was there in the past? |
I think this is not a bug, but might be worth some design review. I can see that this behaviour of showing I can also see that our unit tests expect this value to be in the DOM And that there are github issues going as far back as Apr 2020, without users complaining about that specific part of the screenshot #8452 However, I need to spend more time with the spec to see what was intended? Should the UI show array indices or not? Because this has been this was in MetaMask for years, I am going to remove the bug label, but I will leave it as an enhancement for the Confirmation teams consideration. If you come across any info that shows we are significantly deviating from the intentions of this screen, please do flag it, as we may then escalate in priority |
Thank you both for flagging that and also for identifying it's not a bug. We'll be taking this issue into account as we go through the signTypedData_v4 redesign |
Closing this issue for now |
Describe the bug
There is an element in the signature screen that is out of place or extra, the 0: below To: .
Expected behavior
No extra elements or elements out of place should show.
Screenshots/Recordings
Steps to reproduce
Error messages or log output
No response
Version
11.5.0
Build type
None
Browser
Chrome, Firefox
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: