[Bug]: Element (0:) out of place in sign typed data v4

[benjisclowder]

Describe the bug

There is an element in the signature screen that is out of place or extra, the 0: below To: .

Expected behavior

No extra elements or elements out of place should show.

Screenshots/Recordings

Steps to reproduce

1. Open MetaMask and enter your password
2. Switch over to a test network (e.g.: Sepolia)
3. Head over to the test dapp: https://metamask.github.io/test-dapp/ and connect with current MM account
4. Scroll down to Sign typed data v4 and proceed to the signature screen
5. Notice the 0: below To: which should not show

Error messages or log output

No response

Version

11.5.0

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

[danjm]

@benjisclowder I see the same 0: below the To: on v11.3.0

Is there a reason it should not be there on v11.5.0 even though it was there in the past?

[danjm]

I think this is not a bug, but might be worth some design review.

I can see that this behaviour of showing 0: below the To: existed as far backi as v10.18.0, before the redesign in recent months.

I can also see that our unit tests expect this value to be in the DOM

And that there are github issues going as far back as Apr 2020, without users complaining about that specific part of the screenshot #8452

However, I need to spend more time with the spec to see what was intended? Should the UI show array indices or not? Because this has been this was in MetaMask for years, I am going to remove the bug label, but I will leave it as an enhancement for the Confirmation teams consideration.

If you come across any info that shows we are significantly deviating from the intentions of this screen, please do flag it, as we may then escalate in priority

[bschorchit]

Thank you both for flagging that and also for identifying it's not a bug. We'll be taking this issue into account as we go through the signTypedData_v4 redesign

[bschorchit]

This continues to be true for signatures redesign - I'll check if there's a reason to continue to show or not.

[bschorchit]

Closing this issue for now