-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "User can add custom network during onboarding" flaky tests #22713
Comments
Referring to the console log error, which indicates a timeout for the selector 'import-srp__actions', I verified that the selector correctly matches the page element. TimeoutError: Waiting for element to be located By(css selector, .import-srp__actions) Upon further investigation with Dan, we observed that the page gets redirected to the previous one, as shown in the screenshot, which could be an issue. |
Seems an application code bug, will need ux team to work on it. |
Tested manually and I'm surprised the test ever passes - it seems to be explicitly disabled? |
This test is still flaky, need investigation |
That was taken from the "Tests" tab of this circleCI job https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/68163/workflows/f8f35d0f-3529-4535-adc5-eb9fe0fcac0e/jobs/2252097/tests
The text was updated successfully, but these errors were encountered: