Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "User can add custom network during onboarding" flaky tests #22713

Open
danjm opened this issue Jan 29, 2024 · 5 comments
Open

Fix "User can add custom network during onboarding" flaky tests #22713

danjm opened this issue Jan 29, 2024 · 5 comments
Labels
flaky tests team-extension-platform

Comments

@danjm
Copy link
Contributor

danjm commented Jan 29, 2024 •
edited by chloeYue
Loading

That was taken from the "Tests" tab of this circleCI job https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/68163/workflows/f8f35d0f-3529-4535-adc5-eb9fe0fcac0e/jobs/2252097/tests
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jan 29, 2024
@hjetpoluru hjetpoluru removed their assignment Jan 30, 2024
@hjetpoluru
Copy link
Contributor

Referring to the console log error, which indicates a timeout for the selector 'import-srp__actions', I verified that the selector correctly matches the page element.

TimeoutError: Waiting for element to be located By(css selector, .import-srp__actions)
Wait timed out after 10195ms
at /home/circleci/project/node_modules/selenium-webdriver/lib/webdriver.js:929:17
at processTicksAndRejections (node:internal/process/task_queues:95:5)

Upon further investigation with Dan, we observed that the page gets redirected to the previous one, as shown in the screenshot, which could be an issue.

@chloeYue
Copy link
Contributor

chloeYue commented Feb 5, 2024

Seems an application code bug, will need ux team to work on it.

@legobeat
Copy link
Contributor

legobeat commented Mar 6, 2024 •
edited
Loading

Tested manually and I'm surprised the test ever passes - it seems to be explicitly disabled?

@legobeat
Copy link
Contributor

legobeat commented Mar 8, 2024

@legobeat legobeat mentioned this issue Mar 8, 2024
Merged
13 tasks
legobeat added a commit that referenced this issue Mar 13, 2024
@legobeat
fix: allow onboarding and unlocking wallet without Infura mainnet con…
ef0e1a8 
…nectivity (#23388)

Fixes issue where custom networks are not configurable until after
wallet is unlocked.

## Related issues
- Resolves #23333 
- #22713
- Origin: #20277
@chloeYue
Copy link
Contributor

This test is still flaky, need investigation

@metamaskbot metamaskbot removed the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Sep 26, 2024
@chloeYue chloeYue mentioned this issue Sep 27, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky tests team-extension-platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@danjm @metamaskbot @chloeYue @legobeat @hjetpoluru