[Bug]: Can not add custom network during onboarding

[legobeat]

Describe the bug

Since #20277 , the "Add custom network" and "Allow test networks" controls are disabled. This means that onboarding can not be completed without successful Infura ETH Mainnet connectivity.

Example use-cases would be using MetaMask for signing transactions on an airgapped/firewalled network with a trusted node, in scenarios where the network provider is blocking access to Infura, and in cases where the Infura endpoint is denying access or is otherwise unavailable.

Expected behavior

1. The "Add custom network" control is enabled during initial onboarding and while wallet is otherwise not unlocked, allowing the user to connect to a custom RPC endpoint instead of the preconfigured ones.
2. The "Allow test networks" during initial onboarding and while wallet is otherwise unlocked, allowing the user to select a preconfigured test network instead of a mainnet one.
3. Offline onboarding should be possible - connectivity to a live network should not be required to initialize wallet.

Screenshots/Recordings

no-add-network-p.mp4

Steps to reproduce

1. Open MetaMask in environment where connectivity to Infura is not available
2. Wait at loading spinner until timeout and error message
3. Click button "Switch networks"
4. Attempt to click disabled "Add network" button

Error messages or log output

No response

Version

Present in:

• develop (8f02bcb)
• 11.11.4

Build type

main

Browser

Firefox

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

[legobeat]

• Custom networks can be added before unlocking as of fix: allow onboarding and unlocking wallet without Infura mainnet connectivity #23388
• This is still an issue:

  • Offline onboarding should be possible - connectivity to a live network should not be required to initialize wallet.

Related:

• feat: Prevent rpc node requests on locked state #23175
• feat: Delay network controller provider initialization #23005

[metamaskbot]

Missing release label release-11.14.0 on issue. Adding release label release-11.14.0 on issue, as issue is linked to PR #23388 which has this release label.