chore(deps): Bump notification-controller to ^5.0.1 #24430

mikesposito · 2024-05-08T10:51:59Z

Description

The primary purpose for upgrading this package is to ensure that we are using a version which relies on @metamask/base-controller v5, which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements.

See changelog:
https://github.com/MetaMask/core/blob/%40metamask/notification-controller%405.0.1/packages/notification-controller/CHANGELOG.md

Related issues

Progresses #24140

Manual testing steps

There should be no functional changes in this PR

Screenshots/Recordings

None

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

mikesposito · 2024-05-08T11:28:40Z

@metamaskbot update-policies

metamaskbot · 2024-05-08T11:38:18Z

Policies updated

socket-security · 2024-05-08T11:50:59Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/notification-controller@5.0.2	None	`0`	0 B

🚮 Removed packages: npm/@metamask/notification-controller@3.0.0

View full report↗︎

codecov · 2024-05-08T22:42:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (2cd5813) to head (f75a4af).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #24430   +/-   ##
========================================
  Coverage    69.65%   69.65%           
========================================
  Files         1347     1347           
  Lines        47808    47808           
  Branches     13187    13187           
========================================
  Hits         33300    33300           
  Misses       14508    14508

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-05-09T10:31:33Z

Builds ready [2de8b77]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (540 ± 459 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	121	83	16	7
		domContentLoaded	9	24	12	5	2
		load	53	2560	540	956	459
		domInteractive	9	24	12	5	2

Bundle size diffs [🚀 Bundle size reduced!]

background: -26.45 KiB (-0.81%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

github-actions · 2024-05-13T08:09:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Gudahtt

LGTM!

metamaskbot · 2024-05-21T12:05:48Z

Builds ready [feb1f32]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (962 ± 588 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	59	168	107	32	15
		domContentLoaded	9	63	23	17	8
		load	48	3401	962	1225	588
		domInteractive	9	63	23	17	8

Bundle size diffs [🚀 Bundle size reduced!]

background: -26.45 KiB (-0.78%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-05-22T11:43:33Z

Builds ready [9c49dd4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1046 ± 582 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	158	95	30	15
		domContentLoaded	9	55	15	10	5
		load	54	2948	1046	1211	582
		domInteractive	9	55	15	10	5

Bundle size diffs [🚀 Bundle size reduced!]

background: -26.45 KiB (-0.77%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

legobeat

lgtm!

metamaskbot · 2024-06-05T09:09:04Z

Builds ready [d880714]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (318 ± 307 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	213	98	31	15
		domContentLoaded	8	17	11	2	1
		load	43	2302	318	640	307
		domInteractive	8	17	11	2	1

Bundle size diffs [🚀 Bundle size reduced!]

background: -26.45 KiB (-0.83%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

mcmire · 2024-06-06T20:16:03Z

@metamaskbot update-policies

metamaskbot · 2024-06-06T20:26:47Z

Policies updated

Gudahtt · 2024-06-13T15:18:12Z

@metamaskbot update-policies

metamaskbot · 2024-06-13T15:28:12Z

Policies updated

mcmire · 2024-06-18T19:49:45Z

@metamaskbot update-policies

metamaskbot · 2024-06-18T20:00:06Z

Policies updated

mcmire · 2024-06-25T00:15:02Z

@metamaskbot update-policies

metamaskbot · 2024-06-25T00:25:46Z

Policies updated

metamaskbot · 2024-06-25T00:57:09Z

Builds ready [46cb79a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (41 ± 2 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	57	88	71	9	5
		domContentLoaded	8	13	9	1	1
		load	37	56	41	5	2
		domInteractive	8	13	9	1	1

Bundle size diffs [🚀 Bundle size reduced!]

background: -39.13 KiB (-1.13%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-06-25T21:36:49Z

Builds ready [f75a4af]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (49 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	100	82	10	5
		domContentLoaded	9	19	11	2	1
		load	41	65	49	6	3
		domInteractive	9	19	11	2	1

Bundle size diffs [🚀 Bundle size reduced!]

background: -39.13 KiB (-1.13%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

chore(deps): Bump notification-controller to ^5.0.1

41ab82e

mikesposito requested review from a team as code owners May 8, 2024 10:52

mikesposito mentioned this pull request May 8, 2024

Bring all controller packages up to date with (at least) core release 125.0.0 #24140

Closed

24 tasks

mikesposito added team-wallet-framework dependencies Pull requests that update a dependency file labels May 8, 2024

Update LavaMoat policies

176c840

Merge branch 'develop' into bump-notification-controller

94a1e1f

Merge branch 'develop' into bump-notification-controller

2de8b77

legobeat previously approved these changes May 8, 2024

View reviewed changes

legobeat requested a review from a team May 8, 2024 22:33

Merge branch 'develop' into bump-notification-controller

e1f9d98

Gudahtt previously approved these changes May 14, 2024

View reviewed changes

Merge branch 'develop' into bump-base-controller

f97ac3f

mikesposito dismissed stale reviews from Gudahtt and legobeat via f97ac3f May 21, 2024 09:21

Merge branch 'develop' into bump-notification-controller

feb1f32

Merge branch 'develop' into bump-notification-controller

9c49dd4

legobeat previously approved these changes May 28, 2024

View reviewed changes

Merge branch 'develop' into bump-notification-controller

b2441a6

mikesposito dismissed legobeat’s stale review via b2441a6 May 29, 2024 10:58

Merge branch 'develop' into bump-notification-controller

d880714

Merge branch 'develop' into bump-notification-controller

cc69240

Update LavaMoat policies

850c742

mcmire and others added 4 commits June 6, 2024 16:18

Merge branch 'develop' into bump-notification-controller

22ed123

Merge branch 'develop' into bump-notification-controller

41f218b

Merge branch 'develop' into bump-notification-controller

dd02f70

Merge branch 'develop' into bump-notification-controller

0ddd09b

Update LavaMoat policies

db5be7b

Merge branch 'develop' into bump-notification-controller

0af5114

Update LavaMoat policies

4b42390

Merge branch 'develop' into bump-notification-controller

c0c6c8e

Update LavaMoat policies

46cb79a

Merge branch 'develop' into bump-notification-controller

f75a4af

digiwand approved these changes Jun 25, 2024

View reviewed changes

vthomas13 approved these changes Jun 25, 2024

View reviewed changes

mcmire merged commit 61bd043 into develop Jun 25, 2024
70 checks passed

mcmire deleted the bump-notification-controller branch June 25, 2024 21:46

github-actions bot locked and limited conversation to collaborators Jun 25, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): Bump notification-controller to ^5.0.1 #24430

chore(deps): Bump notification-controller to ^5.0.1 #24430

mikesposito commented May 8, 2024 •

edited by legobeat

Loading

mikesposito commented May 8, 2024

metamaskbot commented May 8, 2024

socket-security bot commented May 8, 2024 •

edited

Loading

codecov bot commented May 8, 2024 •

edited

Loading

metamaskbot commented May 9, 2024

github-actions bot commented May 13, 2024

Gudahtt left a comment

metamaskbot commented May 21, 2024

metamaskbot commented May 22, 2024

legobeat left a comment

metamaskbot commented Jun 5, 2024

mcmire commented Jun 6, 2024

metamaskbot commented Jun 6, 2024

Gudahtt commented Jun 13, 2024

metamaskbot commented Jun 13, 2024

mcmire commented Jun 18, 2024

metamaskbot commented Jun 18, 2024

mcmire commented Jun 25, 2024

metamaskbot commented Jun 25, 2024

metamaskbot commented Jun 25, 2024

metamaskbot commented Jun 25, 2024

chore(deps): Bump notification-controller to ^5.0.1 #24430

chore(deps): Bump notification-controller to ^5.0.1 #24430

Conversation

mikesposito commented May 8, 2024 • edited by legobeat Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

mikesposito commented May 8, 2024

metamaskbot commented May 8, 2024

socket-security bot commented May 8, 2024 • edited Loading

codecov bot commented May 8, 2024 • edited Loading

Codecov Report

metamaskbot commented May 9, 2024

github-actions bot commented May 13, 2024

Gudahtt left a comment

Choose a reason for hiding this comment

metamaskbot commented May 21, 2024

metamaskbot commented May 22, 2024

legobeat left a comment

Choose a reason for hiding this comment

metamaskbot commented Jun 5, 2024

mcmire commented Jun 6, 2024

metamaskbot commented Jun 6, 2024

Gudahtt commented Jun 13, 2024

metamaskbot commented Jun 13, 2024

mcmire commented Jun 18, 2024

metamaskbot commented Jun 18, 2024

mcmire commented Jun 25, 2024

metamaskbot commented Jun 25, 2024

metamaskbot commented Jun 25, 2024

metamaskbot commented Jun 25, 2024

mikesposito commented May 8, 2024 •

edited by legobeat

Loading

socket-security bot commented May 8, 2024 •

edited

Loading

codecov bot commented May 8, 2024 •

edited

Loading