-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump notification-controller to ^5.0.1 #24430
Conversation
@metamaskbot update-policies |
Policies updated |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/notification-controller@3.0.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24430 +/- ##
========================================
Coverage 69.65% 69.65%
========================================
Files 1347 1347
Lines 47808 47808
Branches 13187 13187
========================================
Hits 33300 33300
Misses 14508 14508 ☔ View full report in Codecov by Sentry. |
Builds ready [2de8b77]
Page Load Metrics (540 ± 459 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [feb1f32]
Page Load Metrics (962 ± 588 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [9c49dd4]
Page Load Metrics (1046 ± 582 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Builds ready [d880714]
Page Load Metrics (318 ± 307 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
@metamaskbot update-policies |
Policies updated |
@metamaskbot update-policies |
Policies updated |
@metamaskbot update-policies |
Policies updated |
@metamaskbot update-policies |
Policies updated |
Builds ready [46cb79a]
Page Load Metrics (41 ± 2 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [f75a4af]
Page Load Metrics (49 ± 3 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
The primary purpose for upgrading this package is to ensure that we are using a version which relies on
@metamask/base-controller
v5, which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements.See changelog:
https://github.com/MetaMask/core/blob/%40metamask/notification-controller%405.0.1/packages/notification-controller/CHANGELOG.md
Related issues
Progresses #24140
Manual testing steps
There should be no functional changes in this PR
Screenshots/Recordings
None
Pre-merge author checklist
Pre-merge reviewer checklist