Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a story for UnitInput component #25225

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

Devin-Apps
Copy link
Contributor

@Devin-Apps Devin-Apps commented Jun 11, 2024

Description

This pull request adds a Storybook story for the UnitInput component. The story renders the UnitInput component with several configurable properties, allowing users to interact with and test the component in isolation. The story adheres to the project's standards and provides a clear example of how the UnitInput component can be used.

Related issues

Manual testing steps

  • Go to the latest build of storybook in this PR
  • Navigate to the UnitInput component in the Components/UI folder.

Screenshots/Recordings

25b39d33-9c39-40ba-a069-4fea28f1c58f

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Devin Run

Copy link
Contributor

github-actions bot commented Jun 11, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 13, 2024
@georgewrmarshall georgewrmarshall requested a review from a team June 13, 2024 16:38
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georgewrmarshall
Copy link
Contributor

This may need to be merged with develop to pass test-deps-audit

@garrettbear garrettbear marked this pull request as ready for review June 26, 2024 18:03
@garrettbear garrettbear requested a review from a team as a code owner June 26, 2024 18:03
@garrettbear garrettbear merged commit 7e60c9a into MetaMask:develop Jun 26, 2024
82 of 83 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 19, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was added to branch 12.2.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants