Flaky Test: valut decryp at the SRP holding button point
#25329
Assignees
Labels
flaky tests
release-12.1.0
Issue or pull request that will be included in release 12.1.0
team-extension-platform
Comments
7 tasks
seaona
added a commit
that referenced
this issue
Jun 14, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
This fixes another point of flakiness for the vault decrypt test. The
logs show:
```
[driver] Called 'holdMouseDownOnElement' with arguments [{"text":"Hold to reveal SRP","tag":"span"},2000]
[driver] Called 'findElement' with arguments ["[data-testid=\"srp_text\"]"]
Failure on testcase: 'undefined', for more information see the artifacts tab in CI
```
The problem is that the holding time is not long enough so the srp
element cannot be found. To repro, you can make a small time for the
holding, and you'll see you hit the error. For fixing it we increase the
holding time so we make sure that we'll always hold it until the
required amount of time, within any variation of ci environment
https://github.com/MetaMask/metamask-extension/assets/54408225/3251f205-4802-4f88-bcee-5a93203119a0
- ci :
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/87595/workflows/a9d135e4-ecef-44b6-a564-e8e3ca6813b5/jobs/3210020/steps
Fix:
https://github.com/MetaMask/metamask-extension/assets/54408225/db882cfa-ca2e-4a18-9a15-c0b740def439
[](https://codespaces.new/MetaMask/metamask-extension/pull/25328?quickstart=1)
## **Related issues**
Fixes: #25329
## **Manual testing steps**
1. Go to this page...
2.
3.
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
metamaskbot
added
the
release-12.1.0
hjetpoluru
pushed a commit
that referenced
this issue
Jun 14, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/25328?quickstart=1){kind=link}
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
This fixes another point of flakiness for the vault decrypt test. The
logs show:
```
[driver] Called 'holdMouseDownOnElement' with arguments [{"text":"Hold to reveal SRP","tag":"span"},2000]
[driver] Called 'findElement' with arguments ["[data-testid=\"srp_text\"]"]
Failure on testcase: 'undefined', for more information see the artifacts tab in CI
```
The problem is that the holding time is not long enough so the srp
element cannot be found. To repro, you can make a small time for the
holding, and you'll see you hit the error. For fixing it we increase the
holding time so we make sure that we'll always hold it until the
required amount of time, within any variation of ci environment
https://github.com/MetaMask/metamask-extension/assets/54408225/3251f205-4802-4f88-bcee-5a93203119a0
- ci :
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/87595/workflows/a9d135e4-ecef-44b6-a564-e8e3ca6813b5/jobs/3210020/steps
Fix:
https://github.com/MetaMask/metamask-extension/assets/54408225/db882cfa-ca2e-4a18-9a15-c0b740def439
[](https://codespaces.new/MetaMask/metamask-extension/pull/25328?quickstart=1)
## **Related issues**
Fixes: #25329
## **Manual testing steps**
1. Go to this page...
2.
3.
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
hjetpoluru
pushed a commit
that referenced
this issue
Jun 26, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
This fixes another point of flakiness for the vault decrypt test. The
logs show:
```
[driver] Called 'holdMouseDownOnElement' with arguments [{"text":"Hold to reveal SRP","tag":"span"},2000]
[driver] Called 'findElement' with arguments ["[data-testid=\"srp_text\"]"]
Failure on testcase: 'undefined', for more information see the artifacts tab in CI
```
The problem is that the holding time is not long enough so the srp
element cannot be found. To repro, you can make a small time for the
holding, and you'll see you hit the error. For fixing it we increase the
holding time so we make sure that we'll always hold it until the
required amount of time, within any variation of ci environment
https://github.com/MetaMask/metamask-extension/assets/54408225/3251f205-4802-4f88-bcee-5a93203119a0
- ci :
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/87595/workflows/a9d135e4-ecef-44b6-a564-e8e3ca6813b5/jobs/3210020/steps
Fix:
https://github.com/MetaMask/metamask-extension/assets/54408225/db882cfa-ca2e-4a18-9a15-c0b740def439
[](https://codespaces.new/MetaMask/metamask-extension/pull/25328?quickstart=1)
## **Related issues**
Fixes: #25329
## **Manual testing steps**
1. Go to this page...
2.
3.
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: