Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Smart Transactions UI is different for direct send and send+swap transactions #25345

Closed
sleepytanya opened this issue Jun 14, 2024 · 3 comments
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-transactions Transactions team type-bug

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Jun 14, 2024

Describe the bug

The user interface for Smart Transactions differs between direct send transactions, direct send for native tokens and send+swap transactions. Specifically, for direct sends with native token, the Smart Transaction screen is displayed on the home screen, whereas for send+swap transactions, direct send for non-native tokens, this interface is presented exclusively within the MetaMask popup.
Sometimes for send+swap the popup doesn't appear (last recording) - I'm not sure how to reproduce this behavior.

Expected behavior

Screenshots/Recordings

ETH->ETH

directSend.mov

ETH->SUSHI

sendSwap.mov

BAT->BAT

batBat.mov

Popup doesn't appear:

noPopup.mov

Steps to reproduce

  1. Start Send transaction
  2. Select the same token as an origin and destination (direct send)
  3. Start another Send transaction
  4. Select different destination token (send+swap transaction)
  5. Observe the difference in the UI

Error messages or log output

No response

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@dan437
Copy link
Contributor

dan437 commented Jun 20, 2024

I've removed the regression-RC-12.0.0 label, since we disabled smart transactions for this new Send&Swap feature here: #25422

We will make smart transactions work with Send&Swap in one of the future releases.

@gauthierpetetin gauthierpetetin added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Jun 20, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Sep 18, 2024
@klejeune
Copy link
Contributor

This feature is not currently supported. Closing the ticket.

@klejeune klejeune closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-transactions Transactions team type-bug
Projects
Archived in project
Development

No branches or pull requests

4 participants