Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UX: Limit Send Page width in full screen #25347

Closed
wants to merge 1 commit into from
Closed

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jun 15, 2024

Description

Limits the width of the new Send page. Broken by a3cbcef

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open MetaMask in full screen
  2. Go to the send flow
  3. See width of send form limited

Screenshots/Recordings

Before

After

SCR-20240614-qqnx

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner June 15, 2024 00:05
@darkwing darkwing added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jun 15, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.37%. Comparing base (2aaf565) to head (e3e64d7).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25347   +/-   ##
========================================
  Coverage    65.37%   65.37%           
========================================
  Files         1377     1377           
  Lines        54623    54623           
  Branches     14320    14320           
========================================
  Hits         35709    35709           
  Misses       18914    18914           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [e3e64d7]
Page Load Metrics (124 ± 163 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6410181105
domContentLoaded9161021
load391604124340163
domInteractive8161021
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing closed this Jul 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants