Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The popup for the transactions initiated from a dapp are not shown if user has an unapproved transaction #25361

Closed
sleepytanya opened this issue Jun 17, 2024 · 2 comments

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Jun 17, 2024

Describe the bug

Currently, when a user has an unapproved transaction pending, popups for subsequent transactions initiated from a dApp are not displayed.
If user clicks on a MM budge the notification for the test dapp transaction is shown. After rejecting the fist tx, user can click on MM badge again and see / reject / approve all unapproved dapp transactions.
In some cases after rejecting the first transaction MetaMask shows an error (second video).

Related issues:

#25397

#25393

Slack discussion links:

https://consensys.slack.com/archives/C03ETQA9EPK/p1695933147044299

https://consensys.slack.com/archives/C03ETQA9EPK/p1695932531166009

Expected behavior

Screenshots/Recordings

badge.mov
err.mov
Screenshot 2024-06-17 at 14 02 43

Steps to reproduce

  1. Connect to dapp / test dapp
  2. Trigger any transaction, do not approve it
  3. Switch to another dapp
  4. Trigger transaction from a dapp or switch a network
  5. Notice that popup doesn't appear while the number on the extension icon increased

Error messages or log output

No response

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya changed the title [Bug]: The notifications for the transactions initiated from a dapp are not shown if user has an unapproved transaction (initiated form test dapp) [Bug]: The popup for the transactions initiated from a dapp are not shown if user has an unapproved transaction Jun 17, 2024
@vpintorico vpintorico added the team-transactions Transactions team label Jun 20, 2024
@forest-diggs-consensys
Copy link

@sleepytanya can you confirm that this is not the same as this? #25397

Specifically, if you check the MetaMask popup (in your initial video, it's just behind your main chrome window), do you see these subsequent transaction/approval requests?

@sleepytanya
Copy link
Contributor Author

sleepytanya commented Jun 20, 2024

Yes, I think these probably are also the same bug:
#25393
#25406

I transferred error pic and closing this as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants