Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Firefox outdated browser version #25365

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 17, 2024

Description

The outdated browser version for Firefox has been bumped to 102. Users on older versions of Firefox will now see a warning saying that their browser is outdated. This is inpreparation for updating our minimum supported Firefox version to 102.

102 is the previous ESR version, which matches our browser support policy (we support the current and previous ESR Firefox versions).

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

Run this build with any Firefox version between v91 and 101 (inclusive), and see that the outdated browser version notice appears on the Home screen.

Screenshots/Recordings

None

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt marked this pull request as ready for review June 17, 2024 16:20
@Gudahtt Gudahtt requested a review from a team as a code owner June 17, 2024 16:20
@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.93%. Comparing base (7e6fb5d) to head (80a8569).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25365   +/-   ##
========================================
  Coverage    64.93%   64.93%           
========================================
  Files         1385     1385           
  Lines        54950    54950           
  Branches     14417    14417           
========================================
  Hits         35681    35681           
  Misses       19269    19269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [15f3ca3]
Page Load Metrics (191 ± 202 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63155882210
domContentLoaded8191131
load391496191421202
domInteractive8191131
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1 Bytes (0.00%)

The outdated browser version for Firefox has been bumped to 102. Users
on older versions of Firefox will now see a warning saying that their
browser is outdated. This is inpreparation for updating our minimum
supported Firefox version to 102.

102 is the previous ESR version, which matches our browser support
policy (we support the current and previous ESR Firefox versions).
@Gudahtt Gudahtt force-pushed the bump-outdated-firefox-constant branch from 15f3ca3 to 80a8569 Compare June 20, 2024 16:59
@metamaskbot
Copy link
Collaborator

Builds ready [80a8569]
Page Load Metrics (136 ± 187 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6814682178
domContentLoaded9121010
load411838136390187
domInteractive9121010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1 Bytes (0.00%)

Copy link
Contributor

@HowardBraham HowardBraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this by setting my useragent in Firefox, the message pops up if it's lower than 102.

@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 21, 2024

Nice! Oh sorry I forgot to mention, for anyone else testing this, if you're coming from a fresh install you might hit this problem as well: #25366

@Gudahtt Gudahtt merged commit b4b06da into develop Jun 24, 2024
74 checks passed
@Gudahtt Gudahtt deleted the bump-outdated-firefox-constant branch June 24, 2024 16:38
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-extension-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants