-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: downgrade prettier-eslint to match prettier version #26145
chore: downgrade prettier-eslint to match prettier version #26145
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/eslint@8.44.8, npm/@types/prettier@2.7.2, npm/@typescript-eslint/types@5.59.6, npm/@typescript-eslint/typescript-estree@5.59.6, npm/@typescript-eslint/visitor-keys@5.59.6, npm/prettier-eslint@16.3.0, npm/vue-eslint-parser@9.4.2 |
yarn.lock
Outdated
@@ -34218,7 +34167,17 @@ __metadata: | |||
languageName: node | |||
linkType: hard | |||
|
|||
"typescript@npm:^5.0.4, typescript@npm:^5.2.2, typescript@npm:~5.4.5": | |||
"typescript@npm:^4.5.4": | |||
version: 4.9.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this pulls back typescript
to v4 again, it's also technically already a missing peerDependency of @metamask/eslint-config-typescript
.
Updating @metamask/eslint-config-typescript
, and prettier to v3, will properly remove TS v4.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26145 +/- ##
========================================
Coverage 70.12% 70.12%
========================================
Files 1434 1434
Lines 50285 50285
Branches 13890 13890
========================================
Hits 35259 35259
Misses 15026 15026 ☔ View full report in Codecov by Sentry. |
2e7bb1f
to
4d4f2d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I would like to tackle the Prettier v3 upgrade soon, but let's stay consistent in the meantime. Good catch |
4d4f2d5
to
970124e
Compare
970124e
to
e415f99
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
16388d4
to
8aeceb1
Compare
Prettier 3 isn't compatible with |
8aeceb1
to
937f974
Compare
No release label on PR. Adding release label release-12.5.0 on PR, as PR was added to branch 12.5.0 when release was cut. |
Description
#23106 added a version of
prettier-eslint
which uses prettier v3. This project otherwise uses prettier v2. This downgrades the package to the latest version still supporting prettier v2.Related issues
.prettierignore
file #24828Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist