chore: downgrade prettier-eslint to match prettier version #26145

legobeat · 2024-07-25T21:51:58Z

Description

#23106 added a version of prettier-eslint which uses prettier v3. This project otherwise uses prettier v2. This downgrades the package to the latest version still supporting prettier v2.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-25T21:52:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-07-25T21:52:29Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/eslint@8.56.11	None	`0`	193 kB	types
npm/@types/prettier@2.7.3	None	`0`	49.8 kB	types
npm/@typescript-eslint/types@5.62.0	None	`0`	223 kB	jameshenry
npm/@typescript-eslint/typescript-estree@5.62.0	environment, filesystem	`0`	553 kB	jameshenry
npm/@typescript-eslint/visitor-keys@5.62.0	None	`0`	18.4 kB	jameshenry
npm/prettier-eslint@15.0.1	environment, filesystem	`0`	53.1 kB	zimme
npm/vue-eslint-parser@8.3.0	unsafe	`0`	1 MB	ota-meshi

🚮 Removed packages: npm/@types/eslint@8.44.8, npm/@types/prettier@2.7.2, npm/@typescript-eslint/types@5.59.6, npm/@typescript-eslint/typescript-estree@5.59.6, npm/@typescript-eslint/visitor-keys@5.59.6, npm/prettier-eslint@16.3.0, npm/vue-eslint-parser@9.4.2

View full report↗︎

legobeat · 2024-07-25T21:58:12Z

yarn.lock

@@ -34218,7 +34167,17 @@ __metadata:
  languageName: node
  linkType: hard

-"typescript@npm:^5.0.4, typescript@npm:^5.2.2, typescript@npm:~5.4.5":
+"typescript@npm:^4.5.4":
+  version: 4.9.5


While this pulls back typescript to v4 again, it's also technically already a missing peerDependency of @metamask/eslint-config-typescript.

Updating @metamask/eslint-config-typescript, and prettier to v3, will properly remove TS v4.

codecov · 2024-07-25T22:09:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (cad49eb) to head (22bb329).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26145   +/-   ##
========================================
  Coverage    70.12%   70.12%           
========================================
  Files         1434     1434           
  Lines        50285    50285           
  Branches     13890    13890           
========================================
  Hits         35259    35259           
  Misses       15026    15026

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gudahtt

LGTM!

Gudahtt · 2024-08-01T20:17:00Z

I would like to tackle the Prettier v3 upgrade soon, but let's stay consistent in the meantime. Good catch

socket-security · 2024-08-11T22:10:38Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Mrtenz · 2024-08-12T12:18:44Z

I would like to tackle the Prettier v3 upgrade soon, but let's stay consistent in the meantime. Good catch

Prettier 3 isn't compatible with auto-changelog currently fyi. The v3 API is asynchronous, and updating that is quite a big refactor of auto-changelog last time I checked.

metamaskbot · 2024-09-25T21:10:31Z

No release label on PR. Adding release label release-12.5.0 on PR, as PR was added to branch 12.5.0 when release was cut.

legobeat mentioned this pull request Jul 25, 2024

chore: cleanup .prettierignore file #24828

Merged

7 tasks

legobeat marked this pull request as ready for review July 25, 2024 21:53

legobeat requested a review from a team as a code owner July 25, 2024 21:53

legobeat commented Jul 25, 2024

View reviewed changes

legobeat added dependencies Pull requests that update a dependency file team-security labels Jul 25, 2024

legobeat force-pushed the fix-prettier-eslint-version branch 2 times, most recently from 2e7bb1f to 4d4f2d5 Compare July 26, 2024 20:27

Gudahtt previously approved these changes Aug 1, 2024

View reviewed changes

legobeat force-pushed the fix-prettier-eslint-version branch from 4d4f2d5 to 970124e Compare August 1, 2024 23:04

legobeat requested review from a team August 1, 2024 23:05

legobeat dismissed Gudahtt’s stale review via e415f99 August 11, 2024 22:09

legobeat force-pushed the fix-prettier-eslint-version branch from 970124e to e415f99 Compare August 11, 2024 22:09

legobeat force-pushed the fix-prettier-eslint-version branch 2 times, most recently from 16388d4 to 8aeceb1 Compare August 12, 2024 10:06

Gudahtt approved these changes Aug 12, 2024

View reviewed changes

chore: downgrade prettier-eslint to match prettier version

937f974

legobeat force-pushed the fix-prettier-eslint-version branch from 8aeceb1 to 937f974 Compare August 12, 2024 16:08

legobeat and others added 2 commits August 13, 2024 06:52

Merge branch 'develop' into fix-prettier-eslint-version

7ab0601

Merge branch 'develop' into fix-prettier-eslint-version

22bb329

HowardBraham approved these changes Aug 16, 2024

View reviewed changes

HowardBraham merged commit f659700 into MetaMask:develop Aug 16, 2024
76 of 77 checks passed

github-actions bot locked and limited conversation to collaborators Aug 16, 2024

legobeat deleted the fix-prettier-eslint-version branch August 16, 2024 23:49

metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Sep 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: downgrade prettier-eslint to match prettier version #26145

chore: downgrade prettier-eslint to match prettier version #26145

legobeat commented Jul 25, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Jul 25, 2024

socket-security bot commented Jul 25, 2024 •

edited

Loading

legobeat Jul 25, 2024 •

edited

Loading

codecov bot commented Jul 25, 2024 •

edited

Loading

Gudahtt left a comment

Gudahtt commented Aug 1, 2024

socket-security bot commented Aug 11, 2024 •

edited

Loading

Mrtenz commented Aug 12, 2024

metamaskbot commented Sep 25, 2024

chore: downgrade prettier-eslint to match prettier version #26145

chore: downgrade prettier-eslint to match prettier version #26145

Conversation

legobeat commented Jul 25, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 25, 2024

socket-security bot commented Jul 25, 2024 • edited Loading

legobeat Jul 25, 2024 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jul 25, 2024 • edited Loading

Codecov Report

Gudahtt left a comment

Choose a reason for hiding this comment

Gudahtt commented Aug 1, 2024

socket-security bot commented Aug 11, 2024 • edited Loading

Mrtenz commented Aug 12, 2024

metamaskbot commented Sep 25, 2024

legobeat commented Jul 25, 2024 •

edited by github-actions bot

Loading

socket-security bot commented Jul 25, 2024 •

edited

Loading

legobeat Jul 25, 2024 •

edited

Loading

codecov bot commented Jul 25, 2024 •

edited

Loading

socket-security bot commented Aug 11, 2024 •

edited

Loading