Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Transaction stuck in 'Unapproved' state when Smart Transaction is pending #26360

Closed
sleepytanya opened this issue Aug 10, 2024 · 2 comments
Labels
regression-prod-12.0.1 Regression bug that was found in production in release 12.0.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

To provide some clarity on the current situation: when there is a Smart Transaction (STX) in a 'Pending' state, MM restricts the initiation of other transactions across any network.
However, transactions of the 'Approval' type, whether initiated from a dApp or directly within MetaMask, can still be started. This action leads to the MetaMask popup displaying a perpetual loading spinner, and the transaction is listed as 'Unapproved' in the Activity tab. These 'Unapproved' transactions cannot be rejected or confirmed, even after the STX has been successfully processed.
The issue can be remedied by reloading the extension, after which the 'Unapproved' transaction can be addressed as needed.

Expected behavior

Screenshots/Recordings

unapproved.mov
unapproved1.mov

Steps to reproduce

  1. Send STX
  2. Start Approval transaction on another network
  3. The approval transaction is stuck in 'Pending' state

Error messages or log output

No response

Detection stage

In production (default)

Version

v12.1.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug team-transactions Transactions team regression-prod-12.0.1 Regression bug that was found in production in release 12.0.1 Sev2-normal Normal severity; minor loss of service or inconvenience. labels Aug 10, 2024
@sleepytanya
Copy link
Contributor Author

@dbrans feel free to close if it looks good to you!

On current develop:

  • It remains possible to submit an Approval transaction even while an STX transaction is in a Pending state
  • A relevant message indicating a queued transaction is properly shown
  • The Approval transaction appears in the Activity list marked as Unapproved
  • Users can engage with the Confirmation screen for the Unapproved transaction, although they are unable to cancel it.
  • Once the STX transaction has been submitted, the Approval transaction is successfully confirmed
stxApproval.mov

@dbrans
Copy link
Contributor

dbrans commented Oct 23, 2024

Thanks for the detailed update, @sleepytanya! The behavior you're seeing looks normal, so I'll go ahead and close this bug since the issue isn't happening anymore.

@dbrans dbrans closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-12.0.1 Regression bug that was found in production in release 12.0.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug
Projects
Archived in project
Status: Fixed
Development

No branches or pull requests

2 participants