Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update accounts related packages #27284

Merged
merged 13 commits into from
Oct 7, 2024
Merged

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Sep 19, 2024

Description

Updating packages to use versions coming from the new accounts monorepo.

Open in GitHub Codespaces

Related issues

Related to:

Manual testing steps

Test parts of the extension that closely related to accounts management + HW wallets support.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly self-assigned this Sep 19, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Sep 19, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [36456ee]
Page Load Metrics (1775 ± 112 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27123221701402193
domContentLoaded147823001748231111
load153923261775234112
domInteractive21155473316
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 318 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: -72.32 KiB (-0.89%)

@ccharly ccharly force-pushed the chore/update-accounts-packages branch 2 times, most recently from b02fbc2 to 169140b Compare September 24, 2024 18:33
@metamaskbot
Copy link
Collaborator

Builds ready [169140b]
Page Load Metrics (1973 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16512507196518790
domContentLoaded16442451193618087
load17042499197318388
domInteractive15101502512
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 318 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: -72.34 KiB (-0.89%)

@ccharly ccharly force-pushed the chore/update-accounts-packages branch 3 times, most recently from af8589c to c991601 Compare September 25, 2024 21:09
@metamaskbot
Copy link
Collaborator

Builds ready [c991601]
Page Load Metrics (1649 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27619191574327157
domContentLoaded14151853162512862
load14181878164913665
domInteractive21200554622
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -73.43 KiB (-0.90%)

@ccharly ccharly force-pushed the chore/update-accounts-packages branch from c991601 to aa53ef3 Compare September 26, 2024 07:50
@ccharly ccharly force-pushed the chore/update-accounts-packages branch from aa53ef3 to 720cf81 Compare September 26, 2024 08:39
@ccharly ccharly marked this pull request as ready for review September 26, 2024 09:01
@ccharly ccharly requested review from a team as code owners September 26, 2024 09:01
@ccharly ccharly added the needs-qa Label will automate into QA workspace label Sep 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [720cf81]
Page Load Metrics (2014 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51625421955375180
domContentLoaded16762425198117082
load16802549201419192
domInteractive16121512411
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -73.43 KiB (-0.90%)

@metamaskbot
Copy link
Collaborator

Builds ready [0f337dc]
Page Load Metrics (2139 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31325381969526253
domContentLoaded17732525211217684
load17832602213918589
domInteractive27121522211
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1.18 KiB (0.01%)

package.json Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [8a913b9]
Page Load Metrics (2152 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67224552073393189
domContentLoaded162324152123218105
load166324222152219105
domInteractive228345189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1.18 KiB (0.01%)

danroc
danroc previously approved these changes Sep 27, 2024
@plasmacorral plasmacorral self-assigned this Sep 27, 2024
@plasmacorral plasmacorral added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 27, 2024
"1": "string",
"2": "string"
}
"srcNetworkAllowlist": { "0": "string", "1": "string", "2": "string" },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK why this got pretty-print differently, maybe our prettier/eslint config got updated. Anyway, the CI is happy with that change :)

montelaidev
montelaidev previously approved these changes Sep 30, 2024
@ccharly ccharly removed the request for review from a team September 30, 2024 07:58
@ccharly ccharly dismissed stale reviews from montelaidev and danroc via 1f2da0a October 4, 2024 16:35
Copy link

sonarcloud bot commented Oct 4, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [1f2da0a]
Page Load Metrics (1848 ± 117 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint153523201854241116
domContentLoaded149022911829238114
load149723251848243117
domInteractive21175574120
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1.18 KiB (0.02%)

@plasmacorral
Copy link
Contributor

plasmacorral commented Oct 4, 2024

Tested commit 1fdad0a with Chrome 129 and Firefox 131 in mac sonoma 14.6.1

Tested migration in Chrome from 11.16.16 to 1fdad0a
Tested migration in Firefox from 12.3.0 to 1fdad0a

Was able to add HD accounts, import pk, remove accounts, add hardware, remove hardware account, forget hardware, add and remove SSK accounts, sign, send, lock and unlock, pin and hide accounts, dapp connect.

Also tested fresh install with create new wallet and restore SRP.

@plasmacorral plasmacorral added QA Passed and removed needs-qa Label will automate into QA workspace labels Oct 4, 2024
@ccharly ccharly added this pull request to the merge queue Oct 7, 2024
Merged via the queue into develop with commit e354ad5 Oct 7, 2024
79 of 80 checks passed
@ccharly ccharly deleted the chore/update-accounts-packages branch October 7, 2024 08:09
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 7, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-accounts
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants