feat: better storybook stories for the notification pages #27861
+417
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [cf66689]
Page Load Metrics (1909 ± 109 ms)
Bundle size diffs
|
|
Builds ready [2322c20]
Page Load Metrics (1795 ± 141 ms)
Bundle size diffs
|
Builds ready [36288c3]
Page Load Metrics (1948 ± 98 ms)
Bundle size diffs
|
Builds ready [7f9b8c6]
Page Load Metrics (1990 ± 97 ms)
Bundle size diffs
|
Builds ready [4096501]
Page Load Metrics (1875 ± 42 ms)
Bundle size diffs
|
Builds ready [d44e45b]
Page Load Metrics (1868 ± 64 ms)
Bundle size diffs
|
legobeat
changed the title
Builds ready [14cacbc]
Page Load Metrics (1879 ± 64 ms)
Bundle size diffs
|
Builds ready [5c3ba50]
Page Load Metrics (2121 ± 89 ms)
Bundle size diffs
|
Builds ready [be54666]
Page Load Metrics (2022 ± 98 ms)
Bundle size diffs
|
…ask/metamask-extension into feat/improve-notifications-stories
matteoscurati
commented
Oct 24, 2024
| @@ -4,6 +4,10 @@ | |||
| ; This variable is required | |||
| INFURA_PROJECT_ID=00000000000 | |||
|
|
|||
| ; This variable is not required but it's necessary for the storybook | |||
| ; to render stories that use onchain data. | |||
| INFURA_STORYBOOK_PROJECT_ID= | |||
There was a problem hiding this comment.
This is the new ENV introduced to handle a dedicated Infura ID only for Storybook builds
There was a problem hiding this comment.
We may need to discuss with someone on how we can populate this into our CI system.
matteoscurati
commented
Oct 24, 2024
| ### | ||
| # Storybook | ||
| ### | ||
| - STORYBOOK_ENV: false |
There was a problem hiding this comment.
This ENV is set to false by default
matteoscurati
commented
Oct 24, 2024
| "storybook": "storybook dev -p 6006 -c .storybook", | ||
| "storybook:build": "storybook build -c .storybook -o storybook-build", | ||
| "storybook:deploy": "storybook-to-ghpages --existing-output-dir storybook-build --remote storybook --branch master", | ||
| "storybook": "STORYBOOK_ENV=true storybook dev -p 6006 -c .storybook", |
There was a problem hiding this comment.
In the case of running one of these Storybook-related commands, the STORYBOOK_ENV is set to true
matteoscurati
commented
Oct 24, 2024
| headers: process.env.STORYBOOK_ENV | ||
| ? undefined | ||
| : { | ||
| 'Infura-Source': 'metamask/metamask', |
There was a problem hiding this comment.
This sub-optimal solution was previously introduced to handle a dedicated header for RPC calls to the Infura endpoint. In this PR, the use of this call is managed without the header in the case of a Storybook build
ui/pages/notifications/notification-components/feature-announcement/feature-announcement.tsx
Show resolved
Hide resolved
Prithpal-Sooriya
approved these changes
Oct 24, 2024
Builds ready [312be96]
Page Load Metrics (1740 ± 51 ms)
Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances the Storybook stories for the notification pages. The improvements aim to provide better clarity and usability for developers working with notification components. The changes include more detailed and organized stories, making it easier to understand and test different notification states and components.
### Important
ui/pages/notification-details/notification-details.stories.tsx) need to use an RPC endpoint to fetch certain data"storybook": "STORYBOOK_ENV=true storybook dev -p 6006 -c .storybook",inpackage.json).metamaskrc.dist)ui/helpers/utils/notification.util.ts)Related issues
N/A
Manual testing steps
Screenshots/Recordings
Before
N/A
After
Screen.Recording.2024-10-24.at.17.23.49.mov
Pre-merge author checklist
Pre-merge reviewer checklist