refactor: remove global network usage from transaction simulation #27895
+235
−190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove any usage of the global network from transaction simulation.
This requires using the
chainId
from theTransactionMeta
, and so theSimulationDetails
properties have been simplified to acceptTransactionMeta
directly to minimise the number of tightly coupled properties.Related issues
Fixes: #3376
Manual testing steps
Regression of all simulation usages, with specific attention to fiat value.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist