Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove global network usage from transaction simulation #27895

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Oct 16, 2024

Description

Remove any usage of the global network from transaction simulation.

This requires using the chainId from the TransactionMeta, and so the SimulationDetails properties have been simplified to accept TransactionMeta directly to minimise the number of tightly coupled properties.

Open in GitHub Codespaces

Related issues

Fixes: #3376

Manual testing steps

Regression of all simulation usages, with specific attention to fiat value.

  • Legacy confirmations
  • Redesigned confirmations
  • Smart transaction status

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Add transaction prop to SimulationDetails.
@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Oct 16, 2024
Copy link

sonarcloud bot commented Oct 16, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [bc6e6e3]
Page Load Metrics (2162 ± 202 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36232432041559268
domContentLoaded171731212117404194
load175332862162422202
domInteractive28205724923
backgroundConnect9174433919
firstReactRender452031004019
getState56218178
initialActions01000
loadScripts125825081587347167
setupStore1282392411
uiStartup193337742404477229
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -585 Bytes (-0.01%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants