[Bug]: Navigation between unapproved transactions breaks MM with Cannot read properties of undefined (reading 'length') / Message: Should have a queue. This is likely a bug in React. errors #27913
Assignees
Labels
regression-develop
Regression bug that was found on development branch, but not yet present in production
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-confirmations
Push issues to confirmations team
type-bug
Comments
sleepytanya
added
type-bug
regression-develop
|
Hey @sleepytanya , I also faced this issue at some point, but I am not able to replicate this in latest code: Screen.Recording.2024-10-17.at.3.03.23.PM.mov |
|
@jpuri Screen.Recording.2024-10-18.at.10.56.57.mov |
Merged
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 21, 2024
…ion is approve all (#27985) ## **Description** Navigation in transaction header was broken when one of the transaction is of type Approve All ## **Related issues** Fixes: #27913 ## **Manual testing steps** 1. Go to test dapp 2. Submit any re-designed transaction followed by an approve all transaction 3. Try navigating between transaction using header buttons ## **Screenshots/Recordings** TODO ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-12.8.0
gauthierpetetin
added
release-12.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Navigation between two pending malicious transactions breaks MetaMask with errors:
Cannot read properties of undefined (reading 'length')and
Message: Should have a queue. This is likely a bug in ReactAt the moment, functionalities like
Malicious ERC20 Approval (BUSD)andMalicious Set Approval for Allare not operating as anticipated in both the develop branch and the RC 12.5.0 version on Base and BNB networks.#27909
#27905
If a user initiates two consecutive transactions where the latter is a Malicious Set Approval for All, attempting to navigate between these transactions in the popup triggers an error. However, in the Expanded view, these transactions appear as unapproved and can be successfully processed or cancelled.
Expected behavior
No errors
Screenshots/Recordings
1.mov
2.mov
Steps to reproduce
Malicious Set Approval for AllAlternatively, trigger
Malicious Set Approval for Allfirst and then any button from PPOM section - this will produce another type of error.Error messages or log output
No response
Detection stage
On the development branch
Version
12.4.1
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: