Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): @metamask/eth-json-rpc-filters@^8.0.0->^9.0.0 #27956

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 18, 2024

Description

  • Bump @metamask/eth-json-rpc-filters from ^8.0.0 ^9.0.0.

Open in GitHub Codespaces

Related issues

Based on / Blocked by

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-json-rpc-filters@9.0.0 None +2 372 kB lgbot

🚮 Removed packages: npm/@metamask/eth-json-rpc-filters@8.0.0

View full report↗︎

@legobeat legobeat changed the title deps: @metamask/eth-json-rpc-filters@^8.0.0->^9.0.0 fix(deps(: @metamask/eth-json-rpc-filters@^8.0.0->^9.0.0 Oct 18, 2024
@legobeat legobeat changed the title fix(deps(: @metamask/eth-json-rpc-filters@^8.0.0->^9.0.0 fix(deps): @metamask/eth-json-rpc-filters@^8.0.0->^9.0.0 Oct 18, 2024
@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Oct 18, 2024
@legobeat legobeat marked this pull request as ready for review October 18, 2024 12:12
@legobeat legobeat requested review from a team as code owners October 18, 2024 12:12
@legobeat legobeat marked this pull request as draft October 18, 2024 12:13
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-9 branch 2 times, most recently from e0cfc81 to 10d319a Compare October 22, 2024 13:41
github-merge-queue bot pushed a commit that referenced this pull request Oct 22, 2024
## **Description**
- chore: remove obsolete allow-scripts entries
- deps: @metamask/eth-json-rpc-filters@^7.0.0->^8.0.0
  - https://github.com/MetaMask/eth-json-rpc-filters/releases/tag/v8.0.0
  - remove usage of legacy `metamask/eth-query@3.0.1`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27917?quickstart=1)

## **Related issues**

### Blocking
- #27956

## **Manual testing steps**


## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@legobeat legobeat marked this pull request as ready for review October 22, 2024 23:06
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-9 branch 3 times, most recently from 3057517 to dec2456 Compare October 23, 2024 11:28
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HowardBraham HowardBraham added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@legobeat

This comment was marked as resolved.

@legobeat legobeat added this pull request to the merge queue Oct 24, 2024
Merged via the queue into MetaMask:develop with commit 2cc3f2c Oct 24, 2024
76 checks passed
@legobeat legobeat deleted the deps-eth-json-rpc-filters-9 branch October 24, 2024 03:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file team-security
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants