Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update debugging sentry step 3 #28034

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

Unik0rnMaggie
Copy link
Contributor

@Unik0rnMaggie Unik0rnMaggie commented Oct 23, 2024

Description

When using the command METAMASK_DEBUG=true in the .metamaskrc file and building locally with yarn dist or yarn dist:mv2 MetaMask cannot be loaded on Chrome or Firefox.

By updating Step 3 from development/README.md and using METAMASK_DEBUG=1 the issue is no longer present and the MetaMask extension is loading normally on Chrome and Firefox.

Open in GitHub Codespaces

Related issues

Fixes: Loading issues for MetaMask extension when using METAMASK_DEBUG=true and building locally with yarn dist or yarn dist:mv2

Manual testing steps

  1. Use METAMASK_DEBUG=1 in the .metamaskrc file
  2. Build the project locally with yarn dist or yarn dist:mv2
  3. Open the MetaMask extension and see that it's loading with no issues on Chrome or Firefox

Screenshots/Recordings

Before

Chrome
Firefox

After

Screenshot 2024-10-23 at 10 57 49

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 23, 2024
@Unik0rnMaggie Unik0rnMaggie changed the title Docs:Update Debugging Sentry Step 3 docs: Update Debugging Sentry Step 3 Oct 23, 2024
@Unik0rnMaggie Unik0rnMaggie changed the title docs: Update Debugging Sentry Step 3 docs: update debugging sentry step 3 Oct 23, 2024
@Unik0rnMaggie Unik0rnMaggie added area-documentation Issues relating to documentation, in the codebase and off. team-extension-platform labels Oct 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [49a9a99]
Page Load Metrics (2689 ± 322 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26234371673978469
domContentLoaded195039572651667320
load200339752689670322
domInteractive21182714421
backgroundConnect11191433919
firstReactRender775041539847
getState785302311
initialActions01000
loadScripts140529131991550264
setupStore1496392512
uiStartup224144893021800384
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 23, 2024
@Unik0rnMaggie Unik0rnMaggie marked this pull request as ready for review October 23, 2024 12:46
@Unik0rnMaggie Unik0rnMaggie requested review from kumavis and a team as code owners October 23, 2024 12:46
Copy link
Contributor

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, congrats on your first PR 🔥

@metamaskbot
Copy link
Collaborator

Builds ready [b05c56c]
Page Load Metrics (2139 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint184526012141210101
domContentLoaded17832506209119594
load183926062139208100
domInteractive267951168
backgroundConnect8138453115
firstReactRender573061246531
getState775262411
initialActions01000
loadScripts12991944156417082
setupStore1390412613
uiStartup205330722416259125
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Unik0rnMaggie Unik0rnMaggie added this pull request to the merge queue Oct 24, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [bc9673a]
Page Load Metrics (2196 ± 152 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36731851999577277
domContentLoaded177831602161321154
load184031772196317152
domInteractive30157592814
backgroundConnect10102252411
firstReactRender54133107189
getState572252311
initialActions01000
loadScripts130125741634292140
setupStore1177412613
uiStartup205034322433329158
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@Unik0rnMaggie Unik0rnMaggie added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@Unik0rnMaggie Unik0rnMaggie added this pull request to the merge queue Oct 24, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [d689fe5]
Page Load Metrics (1986 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint18292492198514369
domContentLoaded18182409195013263
load18282430198614067
domInteractive268748199
backgroundConnect996282512
firstReactRender632991114521
getState576332512
initialActions00000
loadScripts13081827145111354
setupStore116628199
uiStartup20322757222617785
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@seaona seaona added this pull request to the merge queue Oct 24, 2024
Merged via the queue into develop with commit 1698011 Oct 24, 2024
76 checks passed
@seaona seaona deleted the docs-update-sentry-debugging-readme branch October 24, 2024 12:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-documentation Issues relating to documentation, in the codebase and off. release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants