fix: Gas changes for low Max base fee and Priority fee #28037
Merged
+27
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if the Max base fee and Priority fee were reduced to very low values, the Network fee wouldn't update accordingly. This is a discrepancy with the gas calculations in the old flows.
What fixes it is, for low enough values of
maxFeePerGas
(low enough to be lower thanminimumFeePerGas
), the Network fee becomes the Max fee --maxFeePerGas
timesgasLimit
directly. Apart from fixing the symptom explained above, this ensures that the Network fee is never higher than the Max fee.The PR also fixes this calculation when it comes to the L2 fees (inside
useTransactionGasFeeEstimate
).It also adds a missing override of
dappSuggestedFees
for bothmaxFeePerGas
andmaxPriorityFeePerGas
(insideuseEIP1559TxFees
).Related issues
Fixes: #27802
Manual testing steps
See original report above.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist