Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support dynamic native token name on gas component #28048

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Oct 23, 2024

Description

Uses the multinetwork ticker.

Open in GitHub Codespaces

Related issues

Fixes: #28001

Manual testing steps

See original ticket linked above.

Screenshots/Recordings

Before

After

Screenshot 2024-10-23 at 16 16 19

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Oct 23, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Oct 23, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner October 23, 2024 15:19
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [dcd8152]
Page Load Metrics (2057 ± 124 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint175028892059265127
domContentLoaded174028582022257123
load174928682057258124
domInteractive18122522411
backgroundConnect1084352512
firstReactRender532951287235
getState6183294220
initialActions01000
loadScripts12872103151419593
setupStore1295392814
uiStartup196531242352355170
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 218 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@@ -32,14 +32,18 @@ export function useFeeCalculations(transactionMeta: TransactionMeta) {
const conversionRate = useSelector(getConversionRate);
const fiatFormatter = useFiatFormatter();

const multichainNetwork = useSelector(getMultichainNetwork);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay in the context of a fix, but long-term this is ultimately still using getProviderConfig where as we'll want to pass in our transaction chain ID somehow.

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Oct 24, 2024
Merged via the queue into develop with commit 2ae9236 Oct 24, 2024
79 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/28001 branch October 24, 2024 09:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
@metamaskbot metamaskbot added release-12.7.0 Issue or pull request that will be included in release 12.7.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 24, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.6.0 on PR. Adding release label release-12.6.0 on PR and removing other release labels(release-12.7.0), as PR was cherry-picked in branch 12.6.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect token being shown on the gas component on redesigned confirmations
4 participants