Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade signature controller to remove global network #28063

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Oct 24, 2024

Description

Upgrade @metamask/signature-controller to remove the global network usage.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Oct 24, 2024
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners October 24, 2024 08:23
Copy link

socket-security bot commented Oct 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask-previews/signature-controller@20.1.0-preview-1800a170 Transitive: environment, network +9 2.11 MB metamaskbot

🚮 Removed packages: npm/@metamask/signature-controller@20.0.0

View full report↗︎

Copy link

socket-security bot commented Oct 24, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/@metamask/eth-json-rpc-middleware@15.0.0 🚫
New author npm/@metamask/eth-json-rpc-infura@10.0.0 🚫
Unstable ownership npm/@metamask/eth-json-rpc-infura@10.0.0 🚫
Network access npm/@metamask/eth-json-rpc-infura@10.0.0 🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@metamask/eth-json-rpc-middleware@15.0.0
  • @SocketSecurity ignore npm/@metamask/eth-json-rpc-infura@10.0.0

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner October 24, 2024 09:27
@metamaskbot
Copy link
Collaborator

Builds ready [fc9b79f]
Page Load Metrics (1768 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1595193417778340
domContentLoaded1582186917406732
load1592192917688239
domInteractive207241136
backgroundConnect97425178
firstReactRender44188863316
getState56715199
initialActions00000
loadScripts1145139412886431
setupStore1166322311
uiStartup17822244196510550
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 18.37 KiB (0.42%)
  • ui: -20 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants