-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [POM] Migrate onboarding infura call privacy e2e tests #28079
Open
devin-ai-integration
wants to merge
22
commits into
develop
Choose a base branch
from
chloe-migrate-onboarding
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+229
−355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metamask-extension into pom-migrate-onboarding
Removed test files that were migrated to TypeScript: - test/e2e/tests/privacy/basic-functionality.spec.js - test/e2e/tests/privacy/onboarding-privacy.spec.js
…k/metamask-extension into chloe-migrate-onboarding # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…k/metamask-extension into chloe-migrate-onboarding
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
chloeYue
changed the title
chore: Convert privacy test files to TypeScript
test: Convert privacy test files to TypeScript
Oct 24, 2024
chloeYue
changed the title
test: Convert privacy test files to TypeScript
test: [POM] Migrate onboarding infura call privacy e2e tests
Oct 24, 2024
Builds ready [390d5be]
Page Load Metrics (2066 ± 98 ms)
Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates onboarding infura call privacy e2e tests to TypeScript and Page Object Model (POM) pattern, improving test stability and maintainability, it also reduced flakiness.
Related issues
Fixes: #28080
Manual testing steps
Check code readability, make sure tests pass.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist