Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding installType to Sentry Tags for easy filtering #28084

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

vthomas13
Copy link
Contributor

@vthomas13 vthomas13 commented Oct 24, 2024

Description

InstallType is a recently added flag to help quickly determine whether a Sentry issue is coming from a natural webstore install, or a developer environment. We want to be able to filter by this flag in the Sentry UI.

Added the tag, but also simplified some previous logic from when I added extensionId to make adding extra attributes less tedious in the future. We can also use this pattern for tags.

Open in GitHub Codespaces

Related issues

Fixes: #27667

Manual testing steps

  1. Open App
  2. Use developer options to trigger a sentry error
  3. Go into Sentry UI and verify that installType is a tag in addition to being in the extra properties.

Screenshots/Recordings

Screenshot 2024-10-24 at 1 04 59 PM

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vthomas13 vthomas13 requested a review from a team as a code owner October 24, 2024 17:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b26345c]
Page Load Metrics (1938 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46923751870361173
domContentLoaded16702304190515575
load16792357193816780
domInteractive19120522813
backgroundConnect973292110
firstReactRender47150972613
getState55618168
initialActions01000
loadScripts12011801142214067
setupStore1094413014
uiStartup18842602216517986
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 37 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: add installation type as tag in Sentry for easying out filtering
2 participants