Part of 17670: Replace Typography with Text in detected-token-address.js #18435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
georgewrmarshall
requested changes
Apr 4, 2023
There was a problem hiding this comment.
Thanks for your contribution! Excellent PR description and screenshots 💯 There was a mistake in the issue that incorrectly mapped the Text component to an h7 tag. Heading tags in html go from h1 - h6. I've update the issue and made a couple of suggestions for the tags. Apologies! If you can make those 2 changes I can approve 👍
|
|
||
| const DetectedTokenAddress = ({ tokenAddress }) => { | ||
| const t = useI18nContext(); | ||
| const [copied, handleCopy] = useCopyToClipboard(); | ||
|
|
||
| return ( | ||
| <Box display={DISPLAY.INLINE_FLEX} className="detected-token-address"> | ||
| <Typography variant={TypographyVariant.H7} color={TextColor.textDefault}> | ||
| <Text variant={TextVariant.bodySm} as="h7" color={TextColor.textDefault}> |
There was a problem hiding this comment.
Update to h6 tag
Suggested change
| <Text variant={TextVariant.bodySm} as="h7" color={TextColor.textDefault}> | |
| <Text variant={TextVariant.bodySm} as="h6" color={TextColor.textDefault}> |
| </Text> | ||
| <Text | ||
| variant={TextVariant.bodySm} | ||
| as="h7" |
There was a problem hiding this comment.
Update to h6 tag
Suggested change
| as="h7" | |
| as="h6" |
|
@georgewrmarshall I have made the requested changes, please review. |
georgewrmarshall
approved these changes
Apr 11, 2023
georgewrmarshall
requested review from
garrettbear
and removed request for
ryanml
georgewrmarshall
added
the
team-design-system
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Updating Typography to Text
detected-token-address.jsPart of: #17670
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.