Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #17670: Replace Typography with Text component in:gas-items-details #19075

Conversation

dhruvv173
Copy link
Contributor

@dhruvv173 dhruvv173 commented May 9, 2023

Explanation

This partially fixes PR
Replaced <Typography> component with <Text> for the file gas-details-item-title.js
Also added new stories to Storybook for the files

  • ui\components\app\gas-details-item\gas-details-item-title\gas-details-item-title.js
  • ui\components\app\gas-details-item\gas-details-item\gas-details-item.js

New Story for gas-details-item.js

image
image

New Story for gas-details-item-title.js

image
image

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner May 9, 2023 15:36
@dhruvv173 dhruvv173 requested a review from montelaidev May 9, 2023 15:36
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173 dhruvv173 changed the title Changes to gas-items-details Part of #17670: Replace Typography with Text component in:gas-items-details May 9, 2023
@dhruvv173
Copy link
Contributor Author

Hey @georgewrmarshall
Please review this PR. Replaced Typography with Text component, added new stories and screenshots for the same, if the changes are correct I will go on with making changes to the remaining files.
Thanks!

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 9, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good nice work on the stories! Left one comment

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @dhruvv173

Copy link
Contributor

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and thanks for adding the story!

@garrettbear garrettbear merged commit c9f4202 into MetaMask:develop May 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
@dhruvv173 dhruvv173 deleted the Part-of-#18714-and-#17670-GasItemDetials branch July 25, 2023 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
3 participants