-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #18714: Replacing deprecated constants in Avatar-Favicon
folder
#19332
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
hey @georgewrmarshall can you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution
Codecov Report
@@ Coverage Diff @@
## develop #19332 +/- ##
===========================================
- Coverage 70.05% 70.05% -0.01%
===========================================
Files 963 963
Lines 37248 37248
Branches 9630 9630
===========================================
- Hits 26094 26092 -2
- Misses 11154 11156 +2
|
Explanation
Replaced deprecated design system and storybook constants in the Avatar-Favicon folder
ui/components/component-library/Avatar-Favicon
Screenshots/Screencaps
Before
After
jest test
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.