Creating story for account-mismatch-warning
#19460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## develop #19460 +/- ##
===========================================
- Coverage 70.04% 70.03% -0.01%
===========================================
Files 962 962
Lines 36875 36875
Branches 9468 9468
===========================================
- Hits 25826 25824 -2
- Misses 11049 11051 +2
|
|
hey @georgewrmarshall could you please review this PR when possible? |
georgewrmarshall
added
the
team-design-system
georgewrmarshall
requested review from
georgewrmarshall and
garrettbear
and removed request for
cryptotavares
georgewrmarshall
approved these changes
Jun 6, 2023
ui/components/ui/account-mismatch-warning/account-mismatch-warning.stories.js
Outdated
Show resolved
Hide resolved
georgewrmarshall
previously approved these changes
Jun 6, 2023
…dhruvv173/metamask-extension into creating/story/account-mismatch-warning
georgewrmarshall
approved these changes
Jun 6, 2023
garrettbear
approved these changes
Jun 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
account-mismatch-warningcomponent and replaced a deprecated constantui/components/ui/account-mismatch-warningScreenshots/Screencaps
Before
Story does not exist in
ui/components/uifolderAfter
covered
jesttestsManual Testing Steps
yarn storybookAccountMismatchWarningstory in UI componentPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.