-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating story for account-mismatch-warning
#19460
Creating story for account-mismatch-warning
#19460
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## develop #19460 +/- ##
===========================================
- Coverage 70.04% 70.03% -0.01%
===========================================
Files 962 962
Lines 36875 36875
Branches 9468 9468
===========================================
- Hits 25826 25824 -2
- Misses 11049 11051 +2
|
hey @georgewrmarshall could you please review this PR when possible? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution @dhruvv173
ui/components/ui/account-mismatch-warning/account-mismatch-warning.stories.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution @dhruvv173
…dhruvv173/metamask-extension into creating/story/account-mismatch-warning
Explanation
account-mismatch-warning
component and replaced a deprecated constantui/components/ui/account-mismatch-warning
Screenshots/Screencaps
Before
Story does not exist in
ui/components/ui
folderAfter
covered
jest
testsManual Testing Steps
yarn storybook
AccountMismatchWarning
story in UI componentPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.