issue-18714: Replaced deprecated constants with enum in EthSignModal and HoldToRevealModal Component

[surajgjadhav]

Explanation

Issue link: #18714
Replaced deprecated constants with enum in eth-sign-modal.js and hold-to-reveal-modal.js
Constants replaced with enum:
DISPLAY -> Display
FLEX_DIRECTION -> FlexDirection
SEVERITIES -> Severity

Screenshots/Screencaps

Before

eth-sign-modal.js:

hold-to-reveal-modal.js:

After

eth-sign-modal.js:

hold-to-reveal-modal.js:

Manual Testing Steps

• run yarn storybook
• open localhost:6006 in browser
• Search for EthSignModal and HoldToRevealModalcomponent

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

LGTM! Nice work on the story 💯 Thanks for your contribution @surajgjadhav

[codecov]

Codecov Report

Merging #19499 (bd1dfad) into develop (789779f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19499      +/-   ##
===========================================
- Coverage    70.04%   70.03%   -0.01%     
===========================================
  Files          962      962              
  Lines        36875    36875              
  Branches      9468     9468              
===========================================
- Hits         25826    25824       -2     
- Misses       11049    11051       +2     

Impacted Files	Coverage Δ
...onents/app/modals/eth-sign-modal/eth-sign-modal.js	45.16% <ø> (ø)
...odals/hold-to-reveal-modal/hold-to-reveal-modal.js	100.00% <ø> (ø)

... and 2 files with indirect coverage changes

[NidhiKJha]

LGTM! Thanks for your contribution 😄