Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: react-inspector@2.3.0->6.0.2 #19540

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jun 9, 2023

Explanation

This bumps the version used directly in ui/components/app/signature-request-original/signature-request-original.component.js to the same version used transitively through storybook.

Manual testing

Sign a signature request through the signature-request-original component.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Jun 9, 2023

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: react-inspector@2.3.1

@legobeat legobeat marked this pull request as ready for review June 9, 2023 06:51
@legobeat legobeat requested review from a team as code owners June 9, 2023 06:51
@legobeat legobeat requested a review from hmalik88 June 9, 2023 06:51
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jun 9, 2023
MaytaSeLo

This comment was marked as spam.

@legobeat legobeat force-pushed the deps-react-inspector branch 4 times, most recently from b580fcf to 8f24a73 Compare June 15, 2023 09:23
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #19540 (5cafec4) into develop (59e0f7b) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19540      +/-   ##
===========================================
- Coverage    68.70%   68.70%   -0.01%     
===========================================
  Files          987      987              
  Lines        37837    37837              
  Branches     10120    10120              
===========================================
- Hits         25995    25993       -2     
- Misses       11842    11844       +2     

see 2 files with indirect coverage changes

@socket-security
Copy link

socket-security bot commented Jun 15, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat
Copy link
Contributor Author

Some legacy here but that's not new or related.

@SocketSecurity ignore is-plain-obj@1.1.0
@SocketSecurity ignore is-plain-obj@2.1.0
@SocketSecurity ignore is-plain-obj@4.1.0

@legobeat legobeat force-pushed the deps-react-inspector branch 6 times, most recently from 687fd36 to da335c2 Compare June 20, 2023 05:13
@legobeat legobeat force-pushed the deps-react-inspector branch 3 times, most recently from f219347 to 440f68e Compare June 27, 2023 04:30
@legobeat legobeat force-pushed the deps-react-inspector branch 2 times, most recently from d83be14 to 2da6828 Compare July 13, 2023 04:49
@legobeat
Copy link
Contributor Author

@metamaskbot update-policies

@legobeat
Copy link
Contributor Author

@metamaskbot update-policies

@legobeat legobeat force-pushed the deps-react-inspector branch 11 times, most recently from dd475c2 to 91b73c6 Compare July 21, 2023 10:51
@legobeat legobeat force-pushed the deps-react-inspector branch 3 times, most recently from 57a0c69 to bbb1bda Compare July 26, 2023 11:06
@legobeat legobeat merged commit 6c294ba into MetaMask:develop Jul 26, 2023
9 checks passed
@legobeat legobeat deleted the deps-react-inspector branch July 26, 2023 13:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants