Part of #18714: Replacing deprecated constants in confirm-subtitle folder
#19699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## develop #19699 +/- ##
===========================================
- Coverage 70.79% 70.79% -0.01%
===========================================
Files 988 988
Lines 38365 38365
Branches 10041 10041
===========================================
- Hits 27160 27158 -2
- Misses 11205 11207 +2
|
georgewrmarshall
requested review from
georgewrmarshall and
garrettbear
and removed request for
PeterYinusa
georgewrmarshall
added
the
team-design-system
georgewrmarshall
requested changes
Jun 21, 2023
There was a problem hiding this comment.
Hey @rohiiittttt, thanks for your contribution. I think we can remove fontWeight altogether here
| FONT_WEIGHT, | ||
| FontWeight, |
There was a problem hiding this comment.
We could actually remove this because the font-weight for bodyMd is already normal
|
@georgewrmarshall i have done the changes please check |
georgewrmarshall
previously approved these changes
Jun 23, 2023
georgewrmarshall
approved these changes
Jun 23, 2023
darkwing
approved these changes
Jun 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Replaced deprecated design system and storybook constants in the confirm-subtitle
ui/components/app/confirm-subtitle
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.