-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #18714: Replacing deprecated constants in confirm-subtitle
folder
#19699
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## develop #19699 +/- ##
===========================================
- Coverage 70.79% 70.79% -0.01%
===========================================
Files 988 988
Lines 38365 38365
Branches 10041 10041
===========================================
- Hits 27160 27158 -2
- Misses 11205 11207 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rohiiittttt, thanks for your contribution. I think we can remove fontWeight altogether here
FONT_WEIGHT, | ||
FontWeight, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could actually remove this because the font-weight for bodyMd is already normal
@georgewrmarshall i have done the changes please check |
Explanation
Replaced deprecated design system and storybook constants in the confirm-subtitle
ui/components/app/confirm-subtitle
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.