Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New BlockaidBannerAlert component #20051

Merged
merged 7 commits into from
Jul 24, 2023

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Jul 17, 2023

Explanation

Fixes: #19257
Blocked by: #19825

Screenshots/Screencaps

Storybook

zzyJXpp0id

Tests

Screen Shot 2023-07-17 at 12 35 09 PM

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand added the team-confirmations-secure-ux-PR PRs from the confirmations team label Jul 17, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [2d87fdd]
Page Load Metrics (1640 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint119204139199
domContentLoaded1502189816409947
load1502189916409947
domInteractive1502189816409947
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 904 bytes
  • common: 1041 bytes

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #20051 (38d603f) into develop (e923110) will increase coverage by 0.01%.
The diff coverage is 95.00%.

@@             Coverage Diff             @@
##           develop   #20051      +/-   ##
===========================================
+ Coverage    69.35%   69.36%   +0.01%     
===========================================
  Files          986      987       +1     
  Lines        37265    37285      +20     
  Branches     10002    10011       +9     
===========================================
+ Hits         25843    25862      +19     
- Misses       11422    11423       +1     
Impacted Files Coverage Δ
shared/constants/security-provider.ts 100.00% <ø> (ø)
...ert/blockaid-banner-alert/blockaid-banner-alert.js 95.00% <95.00%> (ø)

@digiwand digiwand marked this pull request as ready for review July 17, 2023 16:45
@digiwand digiwand requested a review from a team as a code owner July 17, 2023 16:45
jpuri
jpuri previously approved these changes Jul 17, 2023
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

blackdevelopa
blackdevelopa previously approved these changes Jul 18, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI LGTM!

  • Checked storybook build in PR

@digiwand digiwand force-pushed the new-security-provider-banner-alert-component branch from 78c0c17 to 0e151d5 Compare July 20, 2023 10:14
@digiwand digiwand force-pushed the new-security-provider-blockaid-component branch from b967756 to 99333ba Compare July 20, 2023 10:24
Base automatically changed from new-security-provider-banner-alert-component to develop July 21, 2023 09:04
@digiwand digiwand dismissed stale reviews from georgewrmarshall, blackdevelopa, and jpuri July 21, 2023 09:04

The base branch was changed.

@jpuri jpuri mentioned this pull request Jul 21, 2023
@digiwand digiwand force-pushed the new-security-provider-blockaid-component branch from 99333ba to 3c1c948 Compare July 21, 2023 16:47
@metamaskbot
Copy link
Collaborator

Builds ready [38d603f]
Page Load Metrics (1744 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1132741613818
domContentLoaded14632064174317383
load14632064174417383
domInteractive14632063174317383
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 689 Bytes (0.01%)
  • common: 888 Bytes (0.02%)

@jpuri jpuri merged commit 737173e into develop Jul 24, 2023
9 checks passed
@jpuri jpuri deleted the new-security-provider-blockaid-component branch July 24, 2023 06:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 24, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metamask Extension - make blockaid error / warning component configurable
8 participants