Fix/buttonbase ts update #20060
Merged
Fix/buttonbase ts update #20060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
fix error added TextAlignArray resolve deprecated fix lint error by removing textalign prop from textProps button base box updates update buttonbase to use new box and TS
garrettbear
force-pushed
the
fix/buttonbase-ts-update
branch
from
6ce0309
to
dc64796
Compare
Builds ready [1083b90]
Page Load Metrics (1747 ± 66 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #20060 +/- ##
========================================
Coverage 69.37% 69.37%
========================================
Files 987 986 -1
Lines 37292 37296 +4
Branches 10012 10020 +8
========================================
+ Hits 25869 25873 +4
Misses 11423 11423
|
garrettbear
requested review from
darkwing,
georgewrmarshall,
vthomas13 and
NidhiKJha
DDDDDanica
previously approved these changes
Jul 18, 2023
|
LGTM! |
Builds ready [3ab4438]
Page Load Metrics (1589 ± 35 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Looking good. Some things I noticed while testing storybook
- Text is blue on hover when the as prop is an
atag
- `block` dont behave as I expected when `as` prop is an `a` tag
- When `block` is true icons seem to be misaligned
These may have been existing bugs so if you want to create another issue and fix them there that's fine too
ui/components/component-library/button-base/button-base.test.tsx
Outdated
Show resolved
Hide resolved
georgewrmarshall
force-pushed
the
fix/buttonbase-ts-update
branch
from
17b04a4
to
3ab4438
Compare
Builds ready [bce2295]
Page Load Metrics (1510 ± 35 ms)
Bundle size diffs
|
ui/components/component-library/button-base/button-base.stories.tsx
Outdated
Show resolved
Hide resolved
Builds ready [79134d5]
Page Load Metrics (1885 ± 57 ms)
Bundle size diffs
|
georgewrmarshall
added
the
team-design-system
@georgewrmarshall that error is inconsistent because I don't have it. 
|
Builds ready [b428eb9]
Page Load Metrics (1654 ± 58 ms)
Bundle size diffs
|
* fixing as issue * strict prop fixes for george
Builds ready [1c975ea]
Page Load Metrics (1544 ± 40 ms)
Bundle size diffs
|
Builds ready [17988bd]
Page Load Metrics (1553 ± 37 ms)
Bundle size diffs
|
georgewrmarshall
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
LGTM 🔥🔥🔥
- Tested changing
asprop betweenaandbuttonand adding different HTML element specific props likeexternalLinkanddisabled. No incorrect HTML attributes were added and functionality and style was still applied. ✅ - Checked stories and documentation ✅
- Pulled branch to ensure no linting issues in stories or test files ✅
- No use of deprecated components or code e.g consts, js components etc ✅
Builds ready [779ac5e]
Page Load Metrics (1652 ± 55 ms)
Bundle size diffs
|
DDDDDanica
approved these changes
Jul 25, 2023
NidhiKJha
approved these changes
Jul 25, 2023
metamaskbot
added
the
release-10.36.0
Gudahtt
added
release-11.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Update ButtonBase to use TS. No visual change
*Fixes 18886
Screenshots/Screencaps
Before
After
Manual Testing Steps
yarn jest ui/components/component-library/button-basePre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.