fix ts spread props issue

[garrettbear]

Explanation

TS has not been liking us spreading props and at first it seemed like it was strictly a Box component issue but it appears that we just need to Typecast on the spread props for a component. So if it's built using the Text component, you'll need to use the TextProps for typecasting.

Screenshots/Screencaps

Before

After

Manual Testing Steps

Go to a TS component in the component library and toggle between the before and after:
Before: {...props}
After: {...(props as BoxProps<C>)} make sure BoxProps is imported

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Merging #20107 (d277f3d) into develop (6ce80fe) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head d277f3d differs from pull request most recent head e4971dd. Consider uploading reports for the commit e4971dd to get more accurate results

@@             Coverage Diff             @@
##           develop   #20107      +/-   ##
===========================================
+ Coverage    69.34%   69.46%   +0.12%     
===========================================
  Files          986      992       +6     
  Lines        37299    37453     +154     
  Branches     10011    10042      +31     
===========================================
+ Hits         25864    26014     +150     
- Misses       11435    11439       +4     

Impacted Files	Coverage Δ
ui/components/component-library/text/text.tsx	100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

[metamaskbot]

Builds ready [d277f3d]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1815 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	113	220	157	29	14
		domContentLoaded	1496	2220	1815	207	99
		load	1496	2220	1815	207	99
		domInteractive	1496	2220	1815	207	99

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 4 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [e4971dd]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1541 ± 43 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	99	188	129	26	12
		domContentLoaded	1361	1732	1541	89	43
		load	1361	1732	1541	89	43
		domInteractive	1361	1732	1541	89	43

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[georgewrmarshall]

Excellent work 💯