Confirmation page alerts #20125

jpuri · 2023-07-21T10:18:50Z

Adding security alert banners on confirmation pages.

github-actions · 2023-07-21T10:19:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-07-24T10:35:18Z

Builds ready [cc44ac4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1462 ± 31 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	246	134	46	22
		domContentLoaded	1333	1579	1462	66	31
		load	1333	1579	1462	66	31
		domInteractive	1333	1579	1462	66	31

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 48 Bytes (0.00%)
ui: 66 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2023-07-24T10:35:31Z

Codecov Report

Merging #20125 (bd8e6f9) into blockaid_metrics (afef9fd) will increase coverage by 0.02%.
The diff coverage is 82.61%.

❗ Current head bd8e6f9 differs from pull request most recent head 5ac22df. Consider uploading reports for the commit 5ac22df to get more accurate results

@@                 Coverage Diff                  @@
##           blockaid_metrics   #20125      +/-   ##
====================================================
+ Coverage             68.69%   68.72%   +0.02%     
====================================================
  Files                   986      986              
  Lines                 37898    37844      -54     
  Branches              10148    10122      -26     
====================================================
- Hits                  26034    26005      -29     
+ Misses                11864    11839      -25

Files Changed	Coverage Δ
app/scripts/metamask-controller.js	`65.46% <ø> (ø)`
...ontent/confirm-page-container-content.component.js	`91.84% <ø> (ø)`
...der-banner-alert/security-provider-banner-alert.js	`100.00% <ø> (ø)`
...t-original/signature-request-original.component.js	`57.00% <ø> (ø)`
...p/signature-request-siwe/signature-request-siwe.js	`71.93% <ø> (ø)`
...ponents/app/signature-request/signature-request.js	`73.61% <ø> (ø)`
ui/pages/token-allowance/token-allowance.js	`67.97% <ø> (ø)`
app/scripts/lib/ppom/ppom-middleware.ts	`80.00% <33.33%> (-8.89%)`	⬇️
app/scripts/controllers/transactions/index.js	`72.89% <85.71%> (+0.45%)`	⬆️
shared/constants/security-provider.ts	`100.00% <100.00%> (ø)`
... and 1 more

... and 32 files with indirect coverage changes

jpuri · 2023-07-25T10:21:30Z

@metamaskbot update-policies

metamaskbot · 2023-07-25T10:33:39Z

No policy changes

metamaskbot · 2023-07-25T10:56:16Z

Builds ready [54f27c5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1606 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	112	201	134	21	10
		domContentLoaded	1442	1796	1606	114	55
		load	1442	1796	1606	114	55
		domInteractive	1442	1796	1606	114	55

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 48 Bytes (0.00%)
ui: 66 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2023-07-26T09:02:38Z

Builds ready [997c035]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1709 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	119	275	154	34	16
		domContentLoaded	1425	2067	1708	165	79
		load	1425	2082	1709	167	80
		domInteractive	1425	2067	1708	165	79

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 46 Bytes (0.00%)
ui: 66 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2023-07-27T07:40:34Z

Builds ready [bd8e6f9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1666 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	112	237	145	26	12
		domContentLoaded	1449	2151	1664	157	75
		load	1449	2151	1666	159	77
		domInteractive	1449	2151	1664	157	75

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 46 Bytes (0.00%)
ui: 66 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2023-08-01T12:10:19Z

No policy changes

metamaskbot · 2023-08-01T13:18:00Z

Builds ready [d8192ee]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1734 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	122	224	151	22	11
		domContentLoaded	1451	2159	1733	174	83
		load	1451	2159	1734	174	83
		domInteractive	1451	2159	1733	174	83

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 18 Bytes (0.00%)
common: 0 Bytes (0.00%)

app/scripts/lib/ppom/ppom.js

digiwand

currently, the description is

Adding security alert banners on confirmation pages.

can we provide more details please? there also seems to be additional logic added to this PR. It may have been helpful to separate logic into more PRs

example details i think we can add

update app/scripts/lib/ppom/ppom.js
support result_type: Failed key/value
rename ppomResponse → securityAlertResponse
update margin

segun · 2023-08-01T22:01:45Z

ui/components/app/security-provider-banner-alert/blockaid-banner-alert/blockaid-banner-alert.js

+  if (
+    resultType === BlockaidResultType.Benign ||
+    resultType === BlockaidResultType.Failed
+  ) {


According to our discussion @jpuri we are supposed to return the new banner alert when result type is Failed.

@segun : UI changed for failed status will be implemented in a following PR.

could be helpful to add in the description. working on it here:
https://github.com/MetaMask/MetaMask-planning/issues/1056

…sk-extension into confirmation_page_alerts

jpuri · 2023-08-02T12:01:21Z

currently, the description is

Adding security alert banners on confirmation pages.

can we provide more details please? there also seems to be additional logic added to this PR. It may have been helpful to separate logic into more PRs

example details i think we can add

update app/scripts/lib/ppom/ppom.js

support result_type: Failed key/value

rename ppomResponse → securityAlertResponse

update margin

Yep @digiwand : the PR is old and description became stale.

… confirmation_page_alerts

metamaskbot · 2023-08-03T06:00:15Z

Builds ready [d88685e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1610 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	106	317	141	43	21
		domContentLoaded	1421	2056	1610	170	82
		load	1421	2056	1610	170	82
		domInteractive	1421	2056	1610	170	82

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 36 Bytes (0.00%)
common: 0 Bytes (0.00%)

jpuri requested a review from a team July 21, 2023 10:18

jpuri force-pushed the blockaid_metrics branch 2 times, most recently from 6e30484 to 1b9539a Compare July 24, 2023 07:32

jpuri force-pushed the confirmation_page_alerts branch 2 times, most recently from 4cd64a6 to cc03448 Compare July 24, 2023 08:24

jpuri marked this pull request as ready for review July 24, 2023 09:25

jpuri requested a review from a team as a code owner July 24, 2023 09:25

segun previously approved these changes Jul 25, 2023

View reviewed changes

jpuri force-pushed the blockaid_metrics branch from 1387873 to e0ebae6 Compare July 26, 2023 05:31

jpuri requested a review from kumavis as a code owner July 26, 2023 05:31

jpuri force-pushed the confirmation_page_alerts branch 2 times, most recently from 628e2e8 to 6603bf7 Compare July 26, 2023 06:29

Adding metrics events for blockaid

952b89e

jpuri force-pushed the blockaid_metrics branch from db0066d to 952b89e Compare July 26, 2023 08:13

Adding blockaid alert on confirmation pages

3c2e7fd

jpuri force-pushed the confirmation_page_alerts branch from 6603bf7 to 3c2e7fd Compare July 26, 2023 08:14

Fix

997c035

jpuri added 2 commits July 27, 2023 12:32

Update

bba6e59

Update

bd8e6f9

jpuri added 3 commits July 27, 2023 18:17

Update

e2fcb68

Update

6d26d7b

Update

353e0e0

Update

c5205a8

jpuri added 2 commits August 1, 2023 17:41

Update

e499b26

Update

d8192ee

jpuri requested review from segun and digiwand August 1, 2023 12:27

digiwand reviewed Aug 1, 2023

View reviewed changes

app/scripts/lib/ppom/ppom.js Show resolved Hide resolved

jpuri requested a review from digiwand August 1, 2023 14:47

digiwand reviewed Aug 1, 2023

View reviewed changes

segun reviewed Aug 1, 2023

View reviewed changes

jpuri added 3 commits August 2, 2023 05:23

Merge branch 'develop' into confirmation_page_alerts

9fd2df1

Update

7f4a05f

Merge branch 'confirmation_page_alerts' of github.com:MetaMask/metama…

2ac201c

…sk-extension into confirmation_page_alerts

jpuri added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Aug 2, 2023

jpuri requested review from segun and digiwand August 2, 2023 12:01

digiwand mentioned this pull request Aug 2, 2023

Add Blockaid / PPOM Failed Request Security Alert #20362

Merged

8 tasks

jpuri added 2 commits August 3, 2023 10:46

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

6d6ce95

… confirmation_page_alerts

Update

d88685e

cryptotavares approved these changes Aug 3, 2023

View reviewed changes

segun approved these changes Aug 3, 2023

View reviewed changes

jpuri merged commit 8c46f85 into develop Aug 3, 2023
8 of 9 checks passed

jpuri deleted the confirmation_page_alerts branch August 3, 2023 10:54

github-actions bot locked and limited conversation to collaborators Aug 3, 2023

metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Aug 3, 2023

Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Confirmation page alerts #20125

Confirmation page alerts #20125

jpuri commented Jul 21, 2023 •

edited

Loading

github-actions bot commented Jul 21, 2023

metamaskbot commented Jul 24, 2023

codecov bot commented Jul 24, 2023 •

edited

Loading

jpuri commented Jul 25, 2023

metamaskbot commented Jul 25, 2023

metamaskbot commented Jul 25, 2023

metamaskbot commented Jul 26, 2023

metamaskbot commented Jul 27, 2023

metamaskbot commented Aug 1, 2023

metamaskbot commented Aug 1, 2023

digiwand left a comment

segun Aug 1, 2023

jpuri Aug 1, 2023

digiwand Aug 2, 2023

jpuri commented Aug 2, 2023

metamaskbot commented Aug 3, 2023

Confirmation page alerts #20125

Confirmation page alerts #20125

Conversation

jpuri commented Jul 21, 2023 • edited Loading

github-actions bot commented Jul 21, 2023

metamaskbot commented Jul 24, 2023

codecov bot commented Jul 24, 2023 • edited Loading

Codecov Report

jpuri commented Jul 25, 2023

metamaskbot commented Jul 25, 2023

metamaskbot commented Jul 25, 2023

metamaskbot commented Jul 26, 2023

metamaskbot commented Jul 27, 2023

metamaskbot commented Aug 1, 2023

metamaskbot commented Aug 1, 2023

digiwand left a comment

Choose a reason for hiding this comment

segun Aug 1, 2023

Choose a reason for hiding this comment

jpuri Aug 1, 2023

Choose a reason for hiding this comment

digiwand Aug 2, 2023

Choose a reason for hiding this comment

jpuri commented Aug 2, 2023

metamaskbot commented Aug 3, 2023

jpuri commented Jul 21, 2023 •

edited

Loading

codecov bot commented Jul 24, 2023 •

edited

Loading