Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Filter out snaps source code and state from UI state #20136

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

FrederikBolding
Copy link
Member

Explanation

Filters out snaps source code and state from the object being piped to the extension UI. This was previously done in the SnapController but caused issues with persistence, instead we now do it directly in the getState function.

@FrederikBolding FrederikBolding requested a review from a team as a code owner July 22, 2023 10:03
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #20136 (a9c25d8) into develop (e1722d7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #20136      +/-   ##
===========================================
- Coverage    69.35%   69.35%   -0.00%     
===========================================
  Files          986      986              
  Lines        37265    37270       +5     
  Branches     10002    10003       +1     
===========================================
+ Hits         25843    25845       +2     
- Misses       11422    11425       +3     
Impacted Files Coverage Δ
app/scripts/metamask-controller.js 65.86% <100.00%> (-0.12%) ⬇️

@metamaskbot
Copy link
Collaborator

Builds ready [a9c25d8]
Page Load Metrics (2582 ± 126 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1633832615124
domContentLoaded206630642580260125
load206630712582262126
domInteractive206530642580260125
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit b584b82 into develop Jul 24, 2023
10 checks passed
@Mrtenz Mrtenz deleted the fb/filter-snaps-state branch July 24, 2023 13:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 24, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flask release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants