Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Connect MMI flow in one step less #20143

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

albertolive
Copy link
Contributor

@albertolive albertolive commented Jul 24, 2023

Explanation

Shorten the custodian flow and save valuable time by eliminating one unnecessary step.

Expected

Screen.Recording.2023-07-21.at.10.16.32.mov

Current

Screen.Recording.2023-07-21.at.10.17.48.mov

AC

  • There is one step less
  • A PR has been created

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@albertolive albertolive changed the title Bugfix/mmi 3509 custody one step [MMI] Connect MMI in one step less Jul 24, 2023
@albertolive albertolive marked this pull request as ready for review July 24, 2023 11:32
@albertolive albertolive requested a review from a team as a code owner July 24, 2023 11:32
@albertolive albertolive changed the title [MMI] Connect MMI in one step less [MMI] Connect MMI flow in one step less Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #20143 (972d84d) into develop (13faeea) will increase coverage by 0.01%.
The diff coverage is 58.33%.

@@             Coverage Diff             @@
##           develop   #20143      +/-   ##
===========================================
+ Coverage    69.36%   69.36%   +0.01%     
===========================================
  Files          987      987              
  Lines        37287    37284       -3     
  Branches     10011    10010       -1     
===========================================
+ Hits         25861    25862       +1     
+ Misses       11426    11422       -4     
Impacted Files Coverage Δ
ui/pages/institutional/custody/custody.js 51.11% <58.33%> (+1.38%) ⬆️

@metamaskbot
Copy link
Collaborator

Builds ready [972d84d]
Page Load Metrics (1578 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint107167126147
domContentLoaded1452191015789847
load1452191015789847
domInteractive1452191015789847
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@albertolive albertolive merged commit 270f74c into develop Jul 24, 2023
9 checks passed
@albertolive albertolive deleted the bugfix/MMI-3509-custody-one-step branch July 24, 2023 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 24, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants