-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unused useMethodData code #20146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [3997420]
Page Load Metrics (1616 ± 60 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #20146 +/- ##
===========================================
+ Coverage 69.42% 69.44% +0.02%
===========================================
Files 985 984 -1
Lines 37294 37284 -10
Branches 10012 10011 -1
===========================================
Hits 25889 25889
+ Misses 11405 11395 -10 |
DDDDDanica
approved these changes
Jul 24, 2023
NidhiKJha
approved these changes
Jul 25, 2023
pedronfigueiredo
force-pushed
the
fix/remove-use-method-data-code
branch
from
July 25, 2023 09:17
3997420
to
7271087
Compare
metamaskbot
added
the
release-10.36.0
Issue or pull request that will be included in release 10.36.0
label
Jul 25, 2023
Builds ready [7271087]
Page Load Metrics (1523 ± 54 ms)
Bundle size diffs
|
Gudahtt
added
release-11.1.0
Issue or pull request that will be included in release 11.1.0
and removed
release-10.36.0
Issue or pull request that will be included in release 10.36.0
labels
Sep 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.1.0
Issue or pull request that will be included in release 11.1.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Removing unused code in the extension repo. No functional impact.