UX: Allow quick Add Account name based on default name #20168

darkwing · 2023-07-25T02:33:26Z

Explanation

Formerly it was possible to quickly create a new account with the next default account name but this was recently changed. If the new account input is empty, the placeholder value should be used as the account name.

Screenshots/Screencaps

Screen.Recording.2023-07-24.at.9.32.37.PM.mov

Manual Testing Steps

Open the account menu
Click "Add account"
Don't change the value of the Account input (keep it empty)
Click create
See the account created with the placeholder name

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-07-25T02:33:38Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

HowardBraham · 2023-07-25T03:58:14Z

ui/components/multichain/create-account/create-account.js

@@ -43,7 +43,7 @@ export const CreateAccount = ({ onActionComplete }) => {
  const { isValidAccountName, errorMessage } = getAccountNameErrorMessage(
    accounts,
    { t },
-    newAccountName,
+    newAccountName === '' ? defaultAccountName : newAccountName,


This could be shortened and clarified to:
newAccountName ?? defaultAccountName

This ended up nullifying the change. The ?? operator only checks for null and undefined, but the newAccountName is always an empty string if it's unset (never nullish). So the default account name is never used here, leaving the behavior of the component exactly as it was before.

Oh my! Should I fix this? I guess it should be || instead of ??

Yeah exactly! || should work well here. A fix would be appreciated.

We found this during RC testing but this improvement wasn't urgent, so we removed it from the RC. That is, fixing this isn't urgent, so no rush.

metamaskbot · 2023-07-25T04:09:40Z

Builds ready [12fc72f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1577 ± 35 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	109	189	138	24	12
		domContentLoaded	1462	1747	1576	73	35
		load	1463	1747	1577	73	35
		domInteractive	1462	1747	1576	73	35

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 9 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2023-07-25T04:10:04Z

Codecov Report

Merging #20168 (9c6e8db) into develop (d1bc22a) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff            @@
##           develop   #20168   +/-   ##
========================================
  Coverage    69.44%   69.44%           
========================================
  Files          986      986           
  Lines        37291    37293    +2     
  Branches     10014    10015    +1     
========================================
+ Hits         25895    25897    +2     
  Misses       11396    11396

Files Changed	Coverage Δ
ui/components/ui/editable-label/editable-label.js	`60.87% <0.00%> (ø)`
...onents/multichain/create-account/create-account.js	`90.91% <100.00%> (+0.59%)`	⬆️

metamaskbot · 2023-07-25T17:35:23Z

Builds ready [9c6e8db]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1524 ± 39 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	103	159	126	15	7
		domContentLoaded	1398	1723	1524	80	39
		load	1398	1723	1524	80	39
		domInteractive	1398	1722	1524	80	39

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 21 Bytes (0.00%)
common: 0 Bytes (0.00%)

UX: Allow quick Add Account name

12fc72f

darkwing requested a review from a team as a code owner July 25, 2023 02:33

darkwing added the needs-ux-ds-review label Jul 25, 2023

HowardBraham reviewed Jul 25, 2023

View reviewed changes

do not allow account names with just spaces

9c6e8db

kevinghim added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jul 25, 2023

kevinghim assigned darkwing Jul 25, 2023

NidhiKJha approved these changes Jul 26, 2023

View reviewed changes

HowardBraham approved these changes Jul 27, 2023

View reviewed changes

HowardBraham merged commit f584f56 into develop Jul 27, 2023
9 checks passed

HowardBraham deleted the new-account-easy-pass branch July 27, 2023 01:03

github-actions bot locked and limited conversation to collaborators Jul 27, 2023

metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 27, 2023

Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UX: Allow quick Add Account name based on default name #20168

UX: Allow quick Add Account name based on default name #20168

darkwing commented Jul 25, 2023

github-actions bot commented Jul 25, 2023

HowardBraham Jul 25, 2023

Gudahtt Aug 30, 2023

HowardBraham Aug 30, 2023

Gudahtt Aug 30, 2023

metamaskbot commented Jul 25, 2023

codecov bot commented Jul 25, 2023 •

edited

Loading

metamaskbot commented Jul 25, 2023

UX: Allow quick Add Account name based on default name #20168

UX: Allow quick Add Account name based on default name #20168

Conversation

darkwing commented Jul 25, 2023

Explanation

Screenshots/Screencaps

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 25, 2023

HowardBraham Jul 25, 2023

Choose a reason for hiding this comment

Gudahtt Aug 30, 2023

Choose a reason for hiding this comment

HowardBraham Aug 30, 2023

Choose a reason for hiding this comment

Gudahtt Aug 30, 2023

Choose a reason for hiding this comment

metamaskbot commented Jul 25, 2023

codecov bot commented Jul 25, 2023 • edited Loading

Codecov Report

metamaskbot commented Jul 25, 2023

codecov bot commented Jul 25, 2023 •

edited

Loading