Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Fix element UI in MMI #20176

Merged
merged 9 commits into from
Jul 26, 2023
Merged

[MMI] Fix element UI in MMI #20176

merged 9 commits into from
Jul 26, 2023

Conversation

albertolive
Copy link
Contributor

@albertolive albertolive commented Jul 25, 2023

Explanation

Some UI elements, from text to images, need to be updated:

  1. MMI Top logo in Expand view, dark theme, is not the correct one
  2. Text elements with wrong alignment and color
  3. Change default text to use MetaMask Institutional or MMI

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@albertolive albertolive requested a review from a team as a code owner July 25, 2023 13:54
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

zone-live
zone-live previously approved these changes Jul 25, 2023
ui/components/ui/metafox-logo/horizontal-logo.js Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [d0d8cc9]
Page Load Metrics (1526 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1042761333718
domContentLoaded1363169015269546
load1363169115269546
domInteractive1363169015269546
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 774 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #20176 (76c442d) into develop (d262acb) will increase coverage by 0.00%.
The diff coverage is 78.95%.

@@           Coverage Diff            @@
##           develop   #20176   +/-   ##
========================================
  Coverage    68.70%   68.70%           
========================================
  Files          986      987    +1     
  Lines        37817    37835   +18     
  Branches     10116    10120    +4     
========================================
+ Hits         25979    25993   +14     
- Misses       11838    11842    +4     
Files Changed Coverage Δ
...mponents/ui/metafox-logo/metafox-logo.component.js 85.00% <ø> (ø)
ui/pages/home/home.component.js 44.95% <ø> (ø)
...entity-done-page/institutional-entity-done-page.js 100.00% <ø> (ø)
...es/home/institutional/institutional-home-footer.js 71.43% <71.43%> (ø)
ui/components/ui/metafox-logo/horizontal-logo.js 69.23% <77.78%> (+2.56%) ⬆️
ui/components/multichain/app-header/app-header.js 51.28% <100.00%> (+0.42%) ⬆️
ui/pages/unlock-page/unlock-page.component.js 86.27% <100.00%> (+0.56%) ⬆️

zone-live
zone-live previously approved these changes Jul 26, 2023
@albertolive albertolive merged commit 9797d9a into develop Jul 26, 2023
9 checks passed
@albertolive albertolive deleted the MMI-3551-Fix-UI-elements branch July 26, 2023 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 26, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [76c442d]
Page Load Metrics (1622 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1101941402311
domContentLoaded14212130162216680
load14212130162216680
domInteractive14212130162216680
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 774 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants