Improve Account Details E2E tests #20183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [f46a1f4]
Page Load Metrics (1503 ± 23 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #20183 +/- ##
========================================
Coverage 68.69% 68.69%
========================================
Files 986 986
Lines 37815 37815
Branches 10116 10116
========================================
Hits 25977 25977
Misses 11838 11838
|
NidhiKJha
reviewed
Jul 26, 2023
| <Text | ||
| data-testid="account-details-key" | ||
| variant={TextVariant.bodySm} | ||
| style={{ wordBreak: 'break-word' }} |
There was a problem hiding this comment.
I think we can use the overflowWrap property here instead of inline style
Suggested change
| style={{ wordBreak: 'break-word' }} | |
| overflowWrap={OverflowWrap.BreakWord} |
There was a problem hiding this comment.
Just tested and that does not work -- the text breaks well out of the box.
NidhiKJha
added
team-extension-client
team-extension-ux
NidhiKJha
approved these changes
Jul 27, 2023
metamaskbot
added
the
release-10.36.0
Gudahtt
added
release-11.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
With the account details functionality being available from multiple places, we should improve E2Es. These tests ensure the basic functionality works, and that the proper account key is shown when launched from the account menu and global menu.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.