-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Account Details E2E tests #20183
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [f46a1f4]
Page Load Metrics (1503 ± 23 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #20183 +/- ##
========================================
Coverage 68.69% 68.69%
========================================
Files 986 986
Lines 37815 37815
Branches 10116 10116
========================================
Hits 25977 25977
Misses 11838 11838
|
<Text | ||
data-testid="account-details-key" | ||
variant={TextVariant.bodySm} | ||
style={{ wordBreak: 'break-word' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use the overflowWrap
property here instead of inline style
style={{ wordBreak: 'break-word' }} | |
overflowWrap={OverflowWrap.BreakWord} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested and that does not work -- the text breaks well out of the box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation
With the account details functionality being available from multiple places, we should improve E2Es. These tests ensure the basic functionality works, and that the proper account key is shown when launched from the account menu and global menu.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.