Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Account Details E2E tests #20183

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Improve Account Details E2E tests #20183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d28cb83
Improve Account Details E2E tests
darkwing Jul 25, 2023
f46a1f4
Merge branch 'develop' into improve-account-details-e2es
darkwing Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
130 changes: 129 additions & 1 deletion test/e2e/tests/account-details.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,34 @@ describe('Show account details', function () {
},
],
};

const PASSWORD = 'correct horse battery staple';

async function revealPrivateKey(driver, useAccountMenu = true) {
if (useAccountMenu) {
await driver.clickElement('[data-testid="account-menu-icon"]');
await driver.clickElement(
'[data-testid="account-list-item-menu-button"]',
);
await driver.clickElement('[data-testid="account-list-menu-details"]');
} else {
// Global Menu
await driver.clickElement('[data-testid="account-options-menu-button"]');
await driver.clickElement('[data-testid="account-list-menu-details"]');
}

await driver.clickElement({ css: 'button', text: 'Show private key' });

await driver.fill('#account-details-authenticate', PASSWORD);
await driver.press('#account-details-authenticate', driver.Key.ENTER);

const keyContainer = await driver.findElement(
'[data-testid="account-details-key"]',
);
const key = await keyContainer.getText();
return key;
}

it('should show the QR code for the account', async function () {
await withFixtures(
{
Expand All @@ -21,7 +49,7 @@ describe('Show account details', function () {
},
async ({ driver }) => {
await driver.navigate();
await driver.fill('#password', 'correct horse battery staple');
await driver.fill('#password', PASSWORD);
await driver.press('#password', driver.Key.ENTER);

await driver.clickElement('[data-testid="account-menu-icon"]');
Expand All @@ -35,4 +63,104 @@ describe('Show account details', function () {
},
);
});

it('should show the correct private key from account menu', async function () {
await withFixtures(
{
fixtures: new FixtureBuilder().build(),
ganacheOptions,
title: this.test.title,
},
async ({ driver }) => {
await driver.navigate();
await driver.fill('#password', PASSWORD);
await driver.press('#password', driver.Key.ENTER);

const key = await revealPrivateKey(driver);
assert.equal(
key,
'7c9529a67102755b7e6102d6d950ac5d5863c98713805cec576b945b15b71eac',
);
},
);
});

it('should show the correct private key for an unselected account from account menu', async function () {
await withFixtures(
{
fixtures: new FixtureBuilder().build(),
ganacheOptions,
title: this.test.title,
},
async ({ driver }) => {
await driver.navigate();
await driver.fill('#password', PASSWORD);
await driver.press('#password', driver.Key.ENTER);

// Create and focus on different account
await driver.clickElement('[data-testid="account-menu-icon"]');
await driver.clickElement(
'[data-testid="multichain-account-menu-popover-add-account"]',
);
await driver.fill('[placeholder="Account 2"]', '2nd account');
await driver.clickElement({ text: 'Create', tag: 'button' });

const key = await revealPrivateKey(driver);
assert.equal(
key,
'7c9529a67102755b7e6102d6d950ac5d5863c98713805cec576b945b15b71eac',
);
},
);
});

it('should show the correct private key from global menu', async function () {
await withFixtures(
{
fixtures: new FixtureBuilder().build(),
ganacheOptions,
title: this.test.title,
},
async ({ driver }) => {
await driver.navigate();
await driver.fill('#password', PASSWORD);
await driver.press('#password', driver.Key.ENTER);

const key = await revealPrivateKey(driver, false);
assert.equal(
key,
'7c9529a67102755b7e6102d6d950ac5d5863c98713805cec576b945b15b71eac',
);
},
);
});

it('should show the correct private key for a second account from global menu', async function () {
await withFixtures(
{
fixtures: new FixtureBuilder().build(),
ganacheOptions,
title: this.test.title,
},
async ({ driver }) => {
await driver.navigate();
await driver.fill('#password', PASSWORD);
await driver.press('#password', driver.Key.ENTER);

// Create and focus on different account
await driver.clickElement('[data-testid="account-menu-icon"]');
await driver.clickElement(
'[data-testid="multichain-account-menu-popover-add-account"]',
);
await driver.fill('[placeholder="Account 2"]', '2nd account');
await driver.clickElement({ text: 'Create', tag: 'button' });

const key = await revealPrivateKey(driver, false);
assert.equal(
key,
'f444f52ea41e3a39586d7069cb8e8233e9f6b9dea9cbb700cce69ae860661cc8',
);
},
);
});
});
6 changes: 5 additions & 1 deletion ui/components/multichain/account-details/account-details-key.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ export const AccountDetailsKey = ({ accountName, onClose, privateKey }) => {
padding={4}
gap={4}
>
<Text variant={TextVariant.bodySm} style={{ wordBreak: 'break-word' }}>
<Text
data-testid="account-details-key"
variant={TextVariant.bodySm}
style={{ wordBreak: 'break-word' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use the overflowWrap property here instead of inline style

Suggested change
style={{ wordBreak: 'break-word' }}
overflowWrap={OverflowWrap.BreakWord}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and that does not work -- the text breaks well out of the box.

>
{privateKey}
</Text>
<ButtonIcon
Expand Down
Loading