Add Blockaid / PPOM Failed Request Security Alert #20362

digiwand · 2023-08-02T12:03:40Z

Explanation

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1056

Before these changes, we displayed no UI for failed PPOM responses.

This PR adds supporting UI for failed PPOM responses. It optionally hides SecurityProviderBannerAlert footer.

I also snuck in a 1 line fix to fix the alignment of the footer items 8300833

Screenshots/Screencaps

Before

Before, no alert was shown

After

Manual Testing Steps

Run storybook: yarn storybook
See BlockaidBannerAlert page
Change reason value to "Failed"
Observe UI

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-08-02T12:03:53Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-08-02T12:40:38Z

Builds ready [050c8b6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1437 ± 30 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	104	140	119	10	5
		domContentLoaded	1340	1580	1437	61	30
		load	1340	1580	1437	62	30
		domInteractive	1340	1580	1437	61	30

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 18 Bytes (0.00%)
common: 199 Bytes (0.01%)

- proposed to update reason value. planning to update upon update

segun

The screenshot in the PR description doesn't quite align with what's in the figma.

digiwand · 2023-08-03T16:51:28Z

@segun @jpuri updated 814d4fb

codecov · 2023-08-03T18:09:50Z

Codecov Report

Merging #20362 (d276979) into develop (e02f597) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head d276979 differs from pull request most recent head 29f30b0. Consider uploading reports for the commit 29f30b0 to get more accurate results

@@             Coverage Diff             @@
##           develop   #20362      +/-   ##
===========================================
- Coverage    68.84%   68.79%   -0.05%     
===========================================
  Files          993      993              
  Lines        38258    38194      -64     
  Branches     10248    10246       -2     
===========================================
- Hits         26338    26273      -65     
- Misses       11920    11921       +1

Files Changed	Coverage Δ
shared/constants/security-provider.ts	`100.00% <100.00%> (ø)`
...ert/blockaid-banner-alert/blockaid-banner-alert.js	`95.65% <100.00%> (-0.35%)`	⬇️
...der-banner-alert/security-provider-banner-alert.js	`100.00% <100.00%> (ø)`

... and 37 files with indirect coverage changes

metamaskbot · 2023-08-03T18:23:45Z

Builds ready [3d2cf24]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1620 ± 57 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	111	168	134	15	7
		domContentLoaded	1427	1946	1618	118	57
		load	1427	1946	1620	118	57
		domInteractive	1427	1946	1618	118	57

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 199 Bytes (0.01%)

metamaskbot · 2023-08-04T00:02:56Z

Builds ready [d276979]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1493 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	112	167	134	14	7
		domContentLoaded	1382	1826	1493	116	56
		load	1382	1826	1493	116	56
		domInteractive	1382	1826	1493	116	56

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 199 Bytes (0.01%)

metamaskbot · 2023-08-14T15:16:37Z

Builds ready [640297e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1654 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	111	258	170	47	23
		domContentLoaded	1451	1971	1654	154	74
		load	1451	1972	1654	154	74
		domInteractive	1451	1971	1654	154	74

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 199 Bytes (0.01%)

digiwand added the team-confirmations-secure-ux-PR PRs from the confirmations team label Aug 2, 2023

Base automatically changed from confirmation_page_alerts to develop August 3, 2023 10:54

digiwand added 2 commits August 3, 2023 16:46

WIP blockaid: add request failed UI

d817f2b

- proposed to update reason value. planning to update upon update

alphabetize

6fea522

digiwand force-pushed the blockaid-failed-response-ui branch from 050c8b6 to 2fcfbdf Compare August 3, 2023 14:58

digiwand added 2 commits August 3, 2023 17:12

BlockaidBannerAlert: update tkeys based on reason

f5babc0

SecurityProviderBannerAlert: fix footer alignment

8300833

digiwand force-pushed the blockaid-failed-response-ui branch from 2fcfbdf to 8300833 Compare August 3, 2023 15:15

Merge branch 'develop' into blockaid-failed-response-ui

f30056c

digiwand marked this pull request as ready for review August 3, 2023 15:20

digiwand requested a review from a team as a code owner August 3, 2023 15:20

digiwand changed the title ~~blockaid: add request failed UI~~ Add Blockaid / PPOM Failed Request Security Alert Aug 3, 2023

jpuri previously approved these changes Aug 3, 2023

View reviewed changes

segun suggested changes Aug 3, 2023

View reviewed changes

digiwand requested review from segun, jpuri and a team August 3, 2023 16:16

digiwand mentioned this pull request Aug 3, 2023

Blockaid banners implementation MetaMask/metamask-mobile#6585

Merged

3 tasks

digiwand marked this pull request as draft August 3, 2023 16:26

BlockaidBannerAlert: rm footer w failed resultType

814d4fb

digiwand dismissed jpuri’s stale review via 814d4fb August 3, 2023 16:48

Merge branch 'develop' into blockaid-failed-response-ui

3d2cf24

digiwand marked this pull request as ready for review August 3, 2023 16:51

Merge branch 'develop' into blockaid-failed-response-ui

d276979

Merge branch 'develop' into blockaid-failed-response-ui

29f30b0

jpuri approved these changes Aug 14, 2023

View reviewed changes

Merge branch 'develop' into blockaid-failed-response-ui

640297e

segun approved these changes Aug 14, 2023

View reviewed changes

digiwand merged commit 136ede5 into develop Aug 14, 2023
9 checks passed

digiwand deleted the blockaid-failed-response-ui branch August 14, 2023 16:38

github-actions bot locked and limited conversation to collaborators Aug 14, 2023

metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Aug 14, 2023

Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Blockaid / PPOM Failed Request Security Alert #20362

Add Blockaid / PPOM Failed Request Security Alert #20362

digiwand commented Aug 2, 2023 •

edited

Loading

github-actions bot commented Aug 2, 2023

metamaskbot commented Aug 2, 2023

segun left a comment •

edited

Loading

digiwand commented Aug 3, 2023

codecov bot commented Aug 3, 2023 •

edited

Loading

metamaskbot commented Aug 3, 2023

metamaskbot commented Aug 4, 2023

metamaskbot commented Aug 14, 2023

Add Blockaid / PPOM Failed Request Security Alert #20362

Add Blockaid / PPOM Failed Request Security Alert #20362

Conversation

digiwand commented Aug 2, 2023 • edited Loading

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Aug 2, 2023

metamaskbot commented Aug 2, 2023

segun left a comment • edited Loading

Choose a reason for hiding this comment

digiwand commented Aug 3, 2023

codecov bot commented Aug 3, 2023 • edited Loading

Codecov Report

metamaskbot commented Aug 3, 2023

metamaskbot commented Aug 4, 2023

metamaskbot commented Aug 14, 2023

digiwand commented Aug 2, 2023 •

edited

Loading

segun left a comment •

edited

Loading

codecov bot commented Aug 3, 2023 •

edited

Loading