-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Blockaid / PPOM Failed Request Security Alert #20362
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [050c8b6]
Page Load Metrics (1437 ± 30 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
- proposed to update reason value. planning to update upon update
050c8b6
to
2fcfbdf
Compare
2fcfbdf
to
8300833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screenshot in the PR description doesn't quite align with what's in the figma.
Codecov Report
@@ Coverage Diff @@
## develop #20362 +/- ##
===========================================
- Coverage 68.84% 68.79% -0.05%
===========================================
Files 993 993
Lines 38258 38194 -64
Branches 10248 10246 -2
===========================================
- Hits 26338 26273 -65
- Misses 11920 11921 +1
|
Builds ready [3d2cf24]
Page Load Metrics (1620 ± 57 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [d276979]
Page Load Metrics (1493 ± 56 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [640297e]
Page Load Metrics (1654 ± 74 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Explanation
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1056
Before these changes, we displayed no UI for failed PPOM responses.
This PR adds supporting UI for failed PPOM responses. It optionally hides SecurityProviderBannerAlert footer.
I also snuck in a 1 line fix to fix the alignment of the footer items 8300833
Screenshots/Screencaps
Before
Before, no alert was shown
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.