Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Add extend-runtime endowment #20543

Closed
wants to merge 3 commits into from
Closed

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Aug 21, 2023

Explanation

This PR will add support for Snaps Platform endowment that provides extended runtime possibilities by controlling the execution timer.
In this PR added are:

  • Endowment specification (label, description, icon) and its registration to permissions.
  • New allowed event to the Snaps Controller Messenger configuration (ExecutionService:timerPauseRequest).

Related ticket following the work in Snaps repository: MetaMask/snaps#1604

Screenshots/Screencaps

Before

Nothing from before is affected by this PR.

After

TODO: Permission screenshot

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@david0xd david0xd added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Aug 21, 2023
@david0xd david0xd self-assigned this Aug 21, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Nov 20, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale issues and PRs marked as stale team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant